2023-06-12 16:36:22

by Nikolay Borisov

Subject: [PATCH] x86: Remove dead declarations in ia32.h

ia32_pick_mmap_layout got removed in 675a0813609f ("x86: unify mmap_{32|64}.c")
and ia32_setup_arg_pages was removed as part of
32974ad4907c ("[IA64] Remove COMPAT_IA32 support").

Signed-off-by: Nikolay Borisov <[email protected]>
---
arch/x86/include/asm/ia32.h | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/arch/x86/include/asm/ia32.h b/arch/x86/include/asm/ia32.h
index fada857f0a1e..068f6227dfdb 100644
--- a/arch/x86/include/asm/ia32.h
+++ b/arch/x86/include/asm/ia32.h
@@ -59,15 +59,6 @@ struct stat64 {

#define IA32_STACK_TOP IA32_PAGE_OFFSET

-#ifdef __KERNEL__
-struct linux_binprm;
-extern int ia32_setup_arg_pages(struct linux_binprm *bprm,
- unsigned long stack_top, int exec_stack);
-struct mm_struct;
-extern void ia32_pick_mmap_layout(struct mm_struct *mm);
-
-#endif
-
#endif /* CONFIG_IA32_EMULATION */

#endif /* _ASM_X86_IA32_H */
--
2.34.1

2023-07-11 11:49:12

by Nikolay Borisov

Subject: Re: [PATCH] x86: Remove dead declarations in ia32.h

On 12.06.23 г. 18:44 ч., Nikolay Borisov wrote:
> ia32_pick_mmap_layout got removed in 675a0813609f ("x86: unify mmap_{32|64}.c")
> and ia32_setup_arg_pages was removed as part of
> 32974ad4907c ("[IA64] Remove COMPAT_IA32 support").
>
> Signed-off-by: Nikolay Borisov <[email protected]>
> ---
> arch/x86/include/asm/ia32.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/arch/x86/include/asm/ia32.h b/arch/x86/include/asm/ia32.h
> index fada857f0a1e..068f6227dfdb 100644
> --- a/arch/x86/include/asm/ia32.h
> +++ b/arch/x86/include/asm/ia32.h
> @@ -59,15 +59,6 @@ struct stat64 {
>
> #define IA32_STACK_TOP IA32_PAGE_OFFSET
>
> -#ifdef __KERNEL__
> -struct linux_binprm;
> -extern int ia32_setup_arg_pages(struct linux_binprm *bprm,
> - unsigned long stack_top, int exec_stack);
> -struct mm_struct;
> -extern void ia32_pick_mmap_layout(struct mm_struct *mm);
> -
> -#endif
> -
> #endif /* CONFIG_IA32_EMULATION */
>
> #endif /* _ASM_X86_IA32_H */

Ping