2023-06-12 16:53:23

by Tim Harvey

[permalink] [raw]
Subject: [PATCH RESEND v2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes

Remove the unnecessary #address-cells and #size-cells nodes from
the fan-controller. These are not needed as the fan controller does not
have any children.

Signed-off-by: Tim Harvey <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
v2:
- udpated commit log to explain why the nodes are unnessesary
- added Krzysztof's rb tag
---
.../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
index acb9c54942d9..dc379f3ebf24 100644
--- a/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
+++ b/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
@@ -122,12 +122,6 @@ patternProperties:
compatible:
const: gw,gsc-fan

- "#address-cells":
- const: 1
-
- "#size-cells":
- const: 0
-
reg:
description: The fan controller base address
maxItems: 1
@@ -135,8 +129,6 @@ patternProperties:
required:
- compatible
- reg
- - "#address-cells"
- - "#size-cells"

required:
- compatible
@@ -194,8 +186,6 @@ examples:
};

fan-controller@2c {
- #address-cells = <1>;
- #size-cells = <0>;
compatible = "gw,gsc-fan";
reg = <0x2c>;
};
--
2.25.1



2023-06-21 15:43:22

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH RESEND v2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes

On Mon, 12 Jun 2023, Tim Harvey wrote:

> Remove the unnecessary #address-cells and #size-cells nodes from
> the fan-controller. These are not needed as the fan controller does not
> have any children.
>
> Signed-off-by: Tim Harvey <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> ---
> v2:
> - udpated commit log to explain why the nodes are unnessesary
> - added Krzysztof's rb tag
> ---
> .../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ----------
> 1 file changed, 10 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]

2023-06-21 16:15:53

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH RESEND v2] dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes

On Mon, 12 Jun 2023, Tim Harvey wrote:

> Remove the unnecessary #address-cells and #size-cells nodes from
> the fan-controller. These are not needed as the fan controller does not
> have any children.
>
> Signed-off-by: Tim Harvey <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> ---
> v2:
> - udpated commit log to explain why the nodes are unnessesary
> - added Krzysztof's rb tag
> ---
> .../devicetree/bindings/mfd/gateworks-gsc.yaml | 10 ----------
> 1 file changed, 10 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]