2023-06-12 09:34:20

by Bartosz Golaszewski

Subject: [PATCH 09/26] net: stmmac: dwmac-qcom-ethqos: add missing include

From: Bartosz Golaszewski <[email protected]>

device_get_phy_mode() is declared in linux/property.h but this header
is not included.

Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
index e19d142630d3..ecb94e5388c7 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
@@ -6,6 +6,7 @@
#include <linux/of_device.h>
#include <linux/platform_device.h>
#include <linux/phy.h>
+#include <linux/property.h>
#include "stmmac.h"
#include "stmmac_platform.h"

--
2.39.2

2023-06-12 20:15:15

by Andrew Halaney

Subject: Re: [PATCH 09/26] net: stmmac: dwmac-qcom-ethqos: add missing include

On Mon, Jun 12, 2023 at 11:23:38AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> device_get_phy_mode() is declared in linux/property.h but this header
> is not included.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Reviewed-by: Andrew Halaney <[email protected]>

> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> index e19d142630d3..ecb94e5388c7 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> @@ -6,6 +6,7 @@
> #include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/phy.h>
> +#include <linux/property.h>
> #include "stmmac.h"
> #include "stmmac_platform.h"
>
> --
> 2.39.2
>