2023-06-13 07:36:58

by Nylon Chen

[permalink] [raw]
Subject: [PATCH] RISC-V: Support 32_PCREL relocation type in kernel module

Signed-off-by: Nylon Chen <[email protected]>
---
arch/riscv/kernel/module.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
index 7c651d55fcbd..f52d8e3d4b63 100644
--- a/arch/riscv/kernel/module.c
+++ b/arch/riscv/kernel/module.c
@@ -310,6 +310,15 @@ static int apply_r_riscv_sub64_rela(struct module *me, u32 *location,
return 0;
}

+static int apply_r_riscv_pcrel_32_rela(struct module *me, u32 *location,
+ Elf_Addr v)
+{
+ ptrdiff_t offset = (void *)v - (void *)location;
+
+ *location = (*location & 0xffff0000) | (offset & 0xffff);
+ return 0;
+}
+
static int (*reloc_handlers_rela[]) (struct module *me, u32 *location,
Elf_Addr v) = {
[R_RISCV_32] = apply_r_riscv_32_rela,
@@ -335,6 +344,7 @@ static int (*reloc_handlers_rela[]) (struct module *me, u32 *location,
[R_RISCV_SUB16] = apply_r_riscv_sub16_rela,
[R_RISCV_SUB32] = apply_r_riscv_sub32_rela,
[R_RISCV_SUB64] = apply_r_riscv_sub64_rela,
+ [R_RISCV_32_PCREL] = apply_r_riscv_pcrel_32_rela,
};

int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
--
2.40.1



2023-06-13 17:11:57

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] RISC-V: Support 32_PCREL relocation type in kernel module

On Tue, Jun 13, 2023 at 03:26:44PM +0800, Nylon Chen wrote:
> Signed-off-by: Nylon Chen <[email protected]>

You need to write a commit message chief :/
E.g., explain wasn't this needed before and is now.

Cheers,
Conor.


Attachments:
(No filename) (233.00 B)
signature.asc (235.00 B)
Download all attachments