2023-06-13 09:10:04

by Raag Jadav

Subject: [PATCH v3 1/3] pinctrl: intel: refine ->set_mux() hook

Utilize a temporary variable for common shift operation in
->set_mux() hook and improve readability while saving a few bytes.

add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-3 (-3)
Function old new delta
intel_pinmux_set_mux 245 242 -3
Total: Before=10472, After=10469, chg -0.03%

Signed-off-by: Raag Jadav <[email protected]>
---
drivers/pinctrl/intel/pinctrl-intel.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index c7a71c49df0a..e8adf2580321 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -411,18 +411,19 @@ static int intel_pinmux_set_mux(struct pinctrl_dev *pctldev,
/* Now enable the mux setting for each pin in the group */
for (i = 0; i < grp->grp.npins; i++) {
void __iomem *padcfg0;
- u32 value;
+ u32 value, pmode;

padcfg0 = intel_get_padcfg(pctrl, grp->grp.pins[i], PADCFG0);
- value = readl(padcfg0);

+ value = readl(padcfg0);
value &= ~PADCFG0_PMODE_MASK;

if (grp->modes)
- value |= grp->modes[i] << PADCFG0_PMODE_SHIFT;
+ pmode = grp->modes[i];
else
- value |= grp->mode << PADCFG0_PMODE_SHIFT;
+ pmode = grp->mode;

+ value |= pmode << PADCFG0_PMODE_SHIFT;
writel(value, padcfg0);
}

--
2.17.1

2023-06-14 16:35:35

by Andy Shevchenko

Subject: Re: [PATCH v3 1/3] pinctrl: intel: refine ->set_mux() hook

On Tue, Jun 13, 2023 at 02:20:52PM +0530, Raag Jadav wrote:
> Utilize a temporary variable for common shift operation in
> ->set_mux() hook and improve readability while saving a few bytes.
>
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-3 (-3)
> Function old new delta
> intel_pinmux_set_mux 245 242 -3
> Total: Before=10472, After=10469, chg -0.03%

Pushed to my review and testing queue, thanks!

--
With Best Regards,
Andy Shevchenko