2023-06-14 01:58:10

by Jiapeng Chong

Subject: [PATCH] ipv6: clean up some inconsistent indenting

No functional modification involved.

net/ipv6/ip6_offload.c:252 ipv6_gro_receive() warn: inconsistent indenting.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5522
Signed-off-by: Jiapeng Chong <[email protected]>
---
net/ipv6/ip6_offload.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c
index d6314287338d..6c924ba10821 100644
--- a/net/ipv6/ip6_offload.c
+++ b/net/ipv6/ip6_offload.c
@@ -249,10 +249,10 @@ INDIRECT_CALLABLE_SCOPE struct sk_buff *ipv6_gro_receive(struct list_head *head,
* (nlen != (sizeof(*iph2) + ipv6_exthdrs_len(iph2, &ops)))
* memcmp() alone below is sufficient, right?
*/
- if ((first_word & htonl(0xF00FFFFF)) ||
- !ipv6_addr_equal(&iph->saddr, &iph2->saddr) ||
- !ipv6_addr_equal(&iph->daddr, &iph2->daddr) ||
- iph->nexthdr != iph2->nexthdr) {
+ if ((first_word & htonl(0xF00FFFFF)) ||
+ !ipv6_addr_equal(&iph->saddr, &iph2->saddr) ||
+ !ipv6_addr_equal(&iph->daddr, &iph2->daddr) ||
+ iph->nexthdr != iph2->nexthdr) {
not_same_flow:
NAPI_GRO_CB(p)->same_flow = 0;
continue;
--
2.20.1.7.g153144c

2023-06-14 14:40:54

by Simon Horman

Subject: Re: [PATCH] ipv6: clean up some inconsistent indenting

On Wed, Jun 14, 2023 at 09:49:59AM +0800, Jiapeng Chong wrote:
> No functional modification involved.
>
> net/ipv6/ip6_offload.c:252 ipv6_gro_receive() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5522
> Signed-off-by: Jiapeng Chong <[email protected]>

Hi Jiapeng,

unfortunately we don't accept patches that only clean
up code for checkpatch warnings (or similar) for
Networking code.

--
pw-bot: reject