2023-06-15 13:03:02

by Yue Haibing

Subject: [PATCH net-next] net: sched: Remove unused qdisc_l2t()

This is unused since switch to psched_l2t_ns().

Signed-off-by: YueHaibing <[email protected]>
---
include/net/sch_generic.h | 14 --------------
1 file changed, 14 deletions(-)

diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index 12eadecf8cd0..e92f73bb3198 100644
--- a/include/net/sch_generic.h
+++ b/include/net/sch_generic.h
@@ -1190,20 +1190,6 @@ static inline int qdisc_drop_all(struct sk_buff *skb, struct Qdisc *sch,
return NET_XMIT_DROP;
}

-/* Length to Time (L2T) lookup in a qdisc_rate_table, to determine how
- long it will take to send a packet given its size.
- */
-static inline u32 qdisc_l2t(struct qdisc_rate_table* rtab, unsigned int pktlen)
-{
- int slot = pktlen + rtab->rate.cell_align + rtab->rate.overhead;
- if (slot < 0)
- slot = 0;
- slot >>= rtab->rate.cell_log;
- if (slot > 255)
- return rtab->data[255]*(slot >> 8) + rtab->data[slot & 0xFF];
- return rtab->data[slot];
-}
-
struct psched_ratecfg {
u64 rate_bytes_ps; /* bytes per second */
u32 mult;
--
2.34.1

2023-06-15 14:54:58

by Simon Horman

Subject: Re: [PATCH net-next] net: sched: Remove unused qdisc_l2t()

On Thu, Jun 15, 2023 at 08:48:10PM +0800, YueHaibing wrote:
> This is unused since switch to psched_l2t_ns().
>
> Signed-off-by: YueHaibing <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2023-06-17 08:06:18

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: sched: Remove unused qdisc_l2t()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Thu, 15 Jun 2023 20:48:10 +0800 you wrote:
> This is unused since switch to psched_l2t_ns().
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> include/net/sch_generic.h | 14 --------------
> 1 file changed, 14 deletions(-)

Here is the summary with links:
- [net-next] net: sched: Remove unused qdisc_l2t()
https://git.kernel.org/netdev/net-next/c/e16ad981e2a1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html