2023-06-15 15:31:54

by Herve Codina

Subject: [PATCH v5 08/13] iio: inkern: Use max_array() to get the maximum value from an array

Use max_array() to get the maximum value from an array instead of a
custom local loop.

Signed-off-by: Herve Codina <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
---
drivers/iio/inkern.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
index 71d0424383b6..8bfd91f74101 100644
--- a/drivers/iio/inkern.c
+++ b/drivers/iio/inkern.c
@@ -5,6 +5,7 @@
*/
#include <linux/err.h>
#include <linux/export.h>
+#include <linux/minmax.h>
#include <linux/mutex.h>
#include <linux/property.h>
#include <linux/slab.h>
@@ -875,11 +876,7 @@ static int iio_channel_read_max(struct iio_channel *chan,
return -EINVAL;
switch (*type) {
case IIO_VAL_INT:
- *val = vals[--length];
- while (length) {
- if (vals[--length] > *val)
- *val = vals[length];
- }
+ *val = max_array(vals, length);
break;
default:
/* FIXME: learn about max for other iio values */
--
2.40.1

2023-06-17 18:05:57

by Jonathan Cameron

Subject: Re: [PATCH v5 08/13] iio: inkern: Use max_array() to get the maximum value from an array

On Thu, 15 Jun 2023 17:26:26 +0200
Herve Codina <[email protected]> wrote:

> Use max_array() to get the maximum value from an array instead of a
> custom local loop.
>
> Signed-off-by: Herve Codina <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>

Acked-by: Jonathan Cameron <[email protected]>

> ---
> drivers/iio/inkern.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index 71d0424383b6..8bfd91f74101 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -5,6 +5,7 @@
> */
> #include <linux/err.h>
> #include <linux/export.h>
> +#include <linux/minmax.h>
> #include <linux/mutex.h>
> #include <linux/property.h>
> #include <linux/slab.h>
> @@ -875,11 +876,7 @@ static int iio_channel_read_max(struct iio_channel *chan,
> return -EINVAL;
> switch (*type) {
> case IIO_VAL_INT:
> - *val = vals[--length];
> - while (length) {
> - if (vals[--length] > *val)
> - *val = vals[length];
> - }
> + *val = max_array(vals, length);
> break;
> default:
> /* FIXME: learn about max for other iio values */