2023-06-15 16:32:14

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v1 1/1] gpio: xra1403: Remove unused of_gpio.h inclusion

The of_gpio.h is not and shouldn't be used in the GPIO drivers.
Remove it.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/gpio/gpio-xra1403.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c
index 51d6119e1bb4..bbc06cdd9634 100644
--- a/drivers/gpio/gpio-xra1403.c
+++ b/drivers/gpio/gpio-xra1403.c
@@ -11,7 +11,6 @@
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/of_device.h>
-#include <linux/of_gpio.h>
#include <linux/seq_file.h>
#include <linux/spi/spi.h>
#include <linux/regmap.h>
--
2.40.0.1.gaa8946217a0b



2023-06-15 19:13:24

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] gpio: xra1403: Remove unused of_gpio.h inclusion

On Thu, Jun 15, 2023 at 6:26 PM Andy Shevchenko
<[email protected]> wrote:

> The of_gpio.h is not and shouldn't be used in the GPIO drivers.
> Remove it.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2023-06-19 13:06:07

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] gpio: xra1403: Remove unused of_gpio.h inclusion

On Thu, Jun 15, 2023 at 6:26 PM Andy Shevchenko
<[email protected]> wrote:
>
> The of_gpio.h is not and shouldn't be used in the GPIO drivers.
> Remove it.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/gpio/gpio-xra1403.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c
> index 51d6119e1bb4..bbc06cdd9634 100644
> --- a/drivers/gpio/gpio-xra1403.c
> +++ b/drivers/gpio/gpio-xra1403.c
> @@ -11,7 +11,6 @@
> #include <linux/module.h>
> #include <linux/mutex.h>
> #include <linux/of_device.h>
> -#include <linux/of_gpio.h>
> #include <linux/seq_file.h>
> #include <linux/spi/spi.h>
> #include <linux/regmap.h>
> --
> 2.40.0.1.gaa8946217a0b
>

Applied, thanks!

Bart