2023-06-16 03:02:10

by Yang Jihong

[permalink] [raw]
Subject: [PATCH] perf parse: Add missing newline to pr_debug message in evsel__compute_group_pmu_name()

The newline is missing for pr_debug message in
evsel__compute_group_pmu_name(), fix it.

Before:

# perf --debug verbose=2 record -e cpu-clock true
<SNIP>
No PMU found for 'cycles:u'No PMU found for 'instructions:u'------------------------------------------------------------
perf_event_attr:
type 1
size 136
{ sample_period, sample_freq } 4000
sample_type IP|TID|TIME|PERIOD
read_format ID|LOST
disabled 1
inherit 1
mmap 1
comm 1
freq 1
enable_on_exec 1
task 1
sample_id_all 1
exclude_guest 1
mmap2 1
comm_exec 1
ksymbol 1
bpf_event 1
------------------------------------------------------------
<SNIP>

After:

# perf --debug verbose=2 record -e cpu-clock true
<SNIP>
No PMU found for 'cycles:u'
No PMU found for 'instructions:u'
------------------------------------------------------------
perf_event_attr:
type 1
size 136
{ sample_period, sample_freq } 4000
sample_type IP|TID|TIME|PERIOD
read_format ID|LOST
disabled 1
inherit 1
mmap 1
comm 1
freq 1
enable_on_exec 1
task 1
sample_id_all 1
exclude_guest 1
mmap2 1
comm_exec 1
ksymbol 1
bpf_event 1
------------------------------------------------------------
<SNIP>

Signed-off-by: Yang Jihong <[email protected]>
---
tools/perf/util/parse-events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 2d36cadf35ec..bc7274641f34 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -2036,7 +2036,7 @@ static int evsel__compute_group_pmu_name(struct evsel *evsel,
pmu = perf_pmus__scan_core(NULL);
}
if (!pmu) {
- pr_debug("No PMU found for '%s'", evsel__name(evsel));
+ pr_debug("No PMU found for '%s'\n", evsel__name(evsel));
return -EINVAL;
}
group_pmu_name = pmu->name;
--
2.30.GIT



2023-06-20 20:57:56

by Namhyung Kim

[permalink] [raw]
Subject: Re: [PATCH] perf parse: Add missing newline to pr_debug message in evsel__compute_group_pmu_name()

Hello,

On Thu, Jun 15, 2023 at 7:47 PM Yang Jihong <[email protected]> wrote:
>
> The newline is missing for pr_debug message in
> evsel__compute_group_pmu_name(), fix it.
>
> Before:
>
> # perf --debug verbose=2 record -e cpu-clock true
> <SNIP>
> No PMU found for 'cycles:u'No PMU found for 'instructions:u'------------------------------------------------------------
> perf_event_attr:
> type 1
> size 136
> { sample_period, sample_freq } 4000
> sample_type IP|TID|TIME|PERIOD
> read_format ID|LOST
> disabled 1
> inherit 1
> mmap 1
> comm 1
> freq 1
> enable_on_exec 1
> task 1
> sample_id_all 1
> exclude_guest 1
> mmap2 1
> comm_exec 1
> ksymbol 1
> bpf_event 1
> ------------------------------------------------------------
> <SNIP>
>
> After:
>
> # perf --debug verbose=2 record -e cpu-clock true
> <SNIP>
> No PMU found for 'cycles:u'
> No PMU found for 'instructions:u'
> ------------------------------------------------------------
> perf_event_attr:
> type 1
> size 136
> { sample_period, sample_freq } 4000
> sample_type IP|TID|TIME|PERIOD
> read_format ID|LOST
> disabled 1
> inherit 1
> mmap 1
> comm 1
> freq 1
> enable_on_exec 1
> task 1
> sample_id_all 1
> exclude_guest 1
> mmap2 1
> comm_exec 1
> ksymbol 1
> bpf_event 1
> ------------------------------------------------------------
> <SNIP>
>
> Signed-off-by: Yang Jihong <[email protected]>

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung


> ---
> tools/perf/util/parse-events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 2d36cadf35ec..bc7274641f34 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -2036,7 +2036,7 @@ static int evsel__compute_group_pmu_name(struct evsel *evsel,
> pmu = perf_pmus__scan_core(NULL);
> }
> if (!pmu) {
> - pr_debug("No PMU found for '%s'", evsel__name(evsel));
> + pr_debug("No PMU found for '%s'\n", evsel__name(evsel));
> return -EINVAL;
> }
> group_pmu_name = pmu->name;
> --
> 2.30.GIT
>

2023-06-21 17:39:43

by Namhyung Kim

[permalink] [raw]
Subject: Re: [PATCH] perf parse: Add missing newline to pr_debug message in evsel__compute_group_pmu_name()

On Tue, Jun 20, 2023 at 1:32 PM Namhyung Kim <[email protected]> wrote:
>
> Hello,
>
> On Thu, Jun 15, 2023 at 7:47 PM Yang Jihong <[email protected]> wrote:
> >
> > The newline is missing for pr_debug message in
> > evsel__compute_group_pmu_name(), fix it.
> >
> > Before:
> >
> > # perf --debug verbose=2 record -e cpu-clock true
> > <SNIP>
> > No PMU found for 'cycles:u'No PMU found for 'instructions:u'------------------------------------------------------------
> > perf_event_attr:
> > type 1
> > size 136
> > { sample_period, sample_freq } 4000
> > sample_type IP|TID|TIME|PERIOD
> > read_format ID|LOST
> > disabled 1
> > inherit 1
> > mmap 1
> > comm 1
> > freq 1
> > enable_on_exec 1
> > task 1
> > sample_id_all 1
> > exclude_guest 1
> > mmap2 1
> > comm_exec 1
> > ksymbol 1
> > bpf_event 1
> > ------------------------------------------------------------
> > <SNIP>
> >
> > After:
> >
> > # perf --debug verbose=2 record -e cpu-clock true
> > <SNIP>
> > No PMU found for 'cycles:u'
> > No PMU found for 'instructions:u'
> > ------------------------------------------------------------
> > perf_event_attr:
> > type 1
> > size 136
> > { sample_period, sample_freq } 4000
> > sample_type IP|TID|TIME|PERIOD
> > read_format ID|LOST
> > disabled 1
> > inherit 1
> > mmap 1
> > comm 1
> > freq 1
> > enable_on_exec 1
> > task 1
> > sample_id_all 1
> > exclude_guest 1
> > mmap2 1
> > comm_exec 1
> > ksymbol 1
> > bpf_event 1
> > ------------------------------------------------------------
> > <SNIP>
> >
> > Signed-off-by: Yang Jihong <[email protected]>
>
> Acked-by: Namhyung Kim <[email protected]>

Applied to perf-tools-next, thanks!