smatch reports
sound/soc/codecs/max98388.c:890:39: warning: symbol
'soc_codec_dev_max98388' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static.
Signed-off-by: Tom Rix <[email protected]>
---
sound/soc/codecs/max98388.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/max98388.c b/sound/soc/codecs/max98388.c
index 8062a7115007..b7d1d5c7b72f 100644
--- a/sound/soc/codecs/max98388.c
+++ b/sound/soc/codecs/max98388.c
@@ -887,7 +887,7 @@ static const struct regmap_config max98388_regmap = {
.cache_type = REGCACHE_RBTREE,
};
-const struct snd_soc_component_driver soc_codec_dev_max98388 = {
+static const struct snd_soc_component_driver soc_codec_dev_max98388 = {
.probe = max98388_probe,
.controls = max98388_snd_controls,
.num_controls = ARRAY_SIZE(max98388_snd_controls),
--
2.27.0
On Sat, 17 Jun 2023 08:26:35 -0400, Tom Rix wrote:
> smatch reports
> sound/soc/codecs/max98388.c:890:39: warning: symbol
> 'soc_codec_dev_max98388' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static.
>
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: max98388: set variable soc_codec_dev_max98388 storage-class-specifier to static
commit: 320d0e2db9edcde026aac93359624c1d429cb865
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark