Subject: [PATCH 0/2] hwmon: (oxp-sensors) Minor cleanup of driver code

Make some cleanup of the driver removing unnecesary header and some
duplicated return on error logic.

Joaquín Ignacio Aramendía (2):
hwmon: (oxp-sensors) Remove unused header
hwmon: (oxp-sensors) Simplify logic of error return

drivers/hwmon/oxp-sensors.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

--
2.41.0



Subject: [PATCH 2/2] hwmon: (oxp-sensors) Simplify logic of error return

Take return logic on error out of if-else, eliminating
duplicated code in tt_togle_store() function.

Signed-off-by: Joaquín Ignacio Aramendía <[email protected]>
---
drivers/hwmon/oxp-sensors.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
index 584e48d8106e..1e59d97219c4 100644
--- a/drivers/hwmon/oxp-sensors.c
+++ b/drivers/hwmon/oxp-sensors.c
@@ -226,13 +226,12 @@ static ssize_t tt_toggle_store(struct device *dev,

if (value) {
rval = tt_toggle_enable();
- if (rval)
- return rval;
} else {
rval = tt_toggle_disable();
- if (rval)
- return rval;
}
+ if (rval)
+ return rval;
+
return count;
}

--
2.41.0


2023-06-18 16:48:33

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 2/2] hwmon: (oxp-sensors) Simplify logic of error return

On Sat, Jun 17, 2023 at 03:11:43PM -0300, Joaqu?n Ignacio Aramend?a wrote:
> Take return logic on error out of if-else, eliminating
> duplicated code in tt_togle_store() function.
>
> Signed-off-by: Joaqu?n Ignacio Aramend?a <[email protected]>

Applied.

Thanks,
Guenter

> ---
> drivers/hwmon/oxp-sensors.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
> index 584e48d8106e..1e59d97219c4 100644
> --- a/drivers/hwmon/oxp-sensors.c
> +++ b/drivers/hwmon/oxp-sensors.c
> @@ -226,13 +226,12 @@ static ssize_t tt_toggle_store(struct device *dev,
>
> if (value) {
> rval = tt_toggle_enable();
> - if (rval)
> - return rval;
> } else {
> rval = tt_toggle_disable();
> - if (rval)
> - return rval;
> }
> + if (rval)
> + return rval;
> +
> return count;
> }
>