2023-06-19 03:24:10

by Jiasheng Jiang

Subject: [PATCH] rpmsg: glink: Add check for kstrdup

Add check for the return value of kstrdup() and return the error
if it fails in order to avoid NULL pointer dereference.

Fixes: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver")
Signed-off-by: Jiasheng Jiang <[email protected]>
---
drivers/rpmsg/qcom_glink_native.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 1beb40a1d3df..e4015db99899 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -221,6 +221,10 @@ static struct glink_channel *qcom_glink_alloc_channel(struct qcom_glink *glink,

channel->glink = glink;
channel->name = kstrdup(name, GFP_KERNEL);
+ if (!channel->name) {
+ kfree(channel);
+ return ERR_PTR(-ENOMEM);
+ }

init_completion(&channel->open_req);
init_completion(&channel->open_ack);
--
2.25.1

2023-07-15 22:28:58

by Bjorn Andersson

Subject: Re: [PATCH] rpmsg: glink: Add check for kstrdup

On Mon, 19 Jun 2023 11:06:31 +0800, Jiasheng Jiang wrote:
> Add check for the return value of kstrdup() and return the error
> if it fails in order to avoid NULL pointer dereference.
>
>

Applied, thanks!

[1/1] rpmsg: glink: Add check for kstrdup
commit: b5c9ee8296a3760760c7b5d2e305f91412adc795

Best regards,
--
Bjorn Andersson <[email protected]>