The hibernation feature enabled for Xilinx Versal NET SoC in DWC3 IP.
As the DWC3 IP supports the hibernation feature, to handle the wakeup
or hibernation interrupt, add host mode "wakeup" interrupt-names
optional property in the binding schema to capture remote-wakeup and
connect/ disconnect event in the hibernation state and increased maxItems
to 4 for the interrupts and interrupt-names property.
We have a dedicated IRQ line specifically for the hibernation feature.
When the "wakeup" IRQ line is triggered, it initiates a hibernation
interrupt, causing the system to wake up from the hibernation state.
Signed-off-by: Piyush Mehta <[email protected]>
---
Change in V2:
- Addressed ROB review comments
- Updated name of interrupt-names property with "wakeup"
- Move interrupt-names property from dwc3-xilinx core to dwc3 core.
Link: https://lore.kernel.org/all/CAL_JsqK6_7XD7+w+EQvPPmbmSOpfo3JDb0xDN4StuHUm1kgchw@mail.gmail.com/
Change in V3:
- Addressed Krzysztof Kozlowski comments
- Update binding schema enum.
- Upadet commit message.
Link: https://lore.kernel.org/all/[email protected]/
Change in V4:
- Addressed ROB review comments:
- Fixed dt_check warnings
Link: https://lore.kernel.org/lkml/[email protected]/
---
Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index 4f7625955ccc..a696f23730d3 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -44,15 +44,15 @@ properties:
It's either a single common DWC3 interrupt (dwc_usb3) or individual
interrupts for the host, gadget and DRD modes.
minItems: 1
- maxItems: 3
+ maxItems: 4
interrupt-names:
minItems: 1
- maxItems: 3
+ maxItems: 4
oneOf:
- const: dwc_usb3
- items:
- enum: [host, peripheral, otg]
+ enum: [host, peripheral, otg, wakeup]
clocks:
description:
--
2.25.1
On Mon, Jun 19, 2023 at 04:20:32PM +0530, Piyush Mehta wrote:
> The hibernation feature enabled for Xilinx Versal NET SoC in DWC3 IP.
> As the DWC3 IP supports the hibernation feature, to handle the wakeup
> or hibernation interrupt, add host mode "wakeup" interrupt-names
> optional property in the binding schema to capture remote-wakeup and
> connect/ disconnect event in the hibernation state and increased maxItems
> to 4 for the interrupts and interrupt-names property.
>
> We have a dedicated IRQ line specifically for the hibernation feature.
> When the "wakeup" IRQ line is triggered, it initiates a hibernation
> interrupt, causing the system to wake up from the hibernation state.
>
> Signed-off-by: Piyush Mehta <[email protected]>
Acked-by: Conor Dooley <[email protected]>
Cheers,
Conor.
On Mon, 19 Jun 2023 16:20:32 +0530, Piyush Mehta wrote:
> The hibernation feature enabled for Xilinx Versal NET SoC in DWC3 IP.
> As the DWC3 IP supports the hibernation feature, to handle the wakeup
> or hibernation interrupt, add host mode "wakeup" interrupt-names
> optional property in the binding schema to capture remote-wakeup and
> connect/ disconnect event in the hibernation state and increased maxItems
> to 4 for the interrupts and interrupt-names property.
>
> We have a dedicated IRQ line specifically for the hibernation feature.
> When the "wakeup" IRQ line is triggered, it initiates a hibernation
> interrupt, causing the system to wake up from the hibernation state.
>
> Signed-off-by: Piyush Mehta <[email protected]>
> ---
> Change in V2:
> - Addressed ROB review comments
> - Updated name of interrupt-names property with "wakeup"
> - Move interrupt-names property from dwc3-xilinx core to dwc3 core.
>
> Link: https://lore.kernel.org/all/CAL_JsqK6_7XD7+w+EQvPPmbmSOpfo3JDb0xDN4StuHUm1kgchw@mail.gmail.com/
>
> Change in V3:
> - Addressed Krzysztof Kozlowski comments
> - Update binding schema enum.
> - Upadet commit message.
>
> Link: https://lore.kernel.org/all/[email protected]/
>
> Change in V4:
> - Addressed ROB review comments:
> - Fixed dt_check warnings
>
> Link: https://lore.kernel.org/lkml/[email protected]/
> ---
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <[email protected]>