2023-06-19 11:31:28

by Li Dong

Subject: [PATCH] tools: Optimize the variable with 0 as the return value

The variable ret is not used, replacing ret with 0 as the return value

Signed-off-by: Li Dong <[email protected]>
---
tools/perf/util/intel-pt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
index dbf0bc71a63b..a40017458185 100644
--- a/tools/perf/util/intel-pt.c
+++ b/tools/perf/util/intel-pt.c
@@ -3398,7 +3398,6 @@ static int intel_pt_text_poke(struct intel_pt *pt, union perf_event *event)
struct machine *machine = pt->machine;
struct intel_pt_cache_entry *e;
u64 offset;
- int ret = 0;

addr_location__init(&al);
if (!event->text_poke.new_len)
@@ -3439,7 +3438,7 @@ static int intel_pt_text_poke(struct intel_pt *pt, union perf_event *event)
}
out:
addr_location__exit(&al);
- return ret;
+ return 0;
}

static int intel_pt_process_event(struct perf_session *session,
--
2.31.1.windows.1

2023-06-19 13:06:06

by Adrian Hunter

Subject: Re: [PATCH] tools: Optimize the variable with 0 as the return value

On 19/06/23 14:20, Li Dong wrote:
> The variable ret is not used, replacing ret with 0 as the return value

What kernel does that apply to?

>
> Signed-off-by: Li Dong <[email protected]>
> ---
> tools/perf/util/intel-pt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
> index dbf0bc71a63b..a40017458185 100644
> --- a/tools/perf/util/intel-pt.c
> +++ b/tools/perf/util/intel-pt.c
> @@ -3398,7 +3398,6 @@ static int intel_pt_text_poke(struct intel_pt *pt, union perf_event *event)
> struct machine *machine = pt->machine;
> struct intel_pt_cache_entry *e;
> u64 offset;
> - int ret = 0;
>
> addr_location__init(&al);
> if (!event->text_poke.new_len)
> @@ -3439,7 +3438,7 @@ static int intel_pt_text_poke(struct intel_pt *pt, union perf_event *event)
> }
> out:
> addr_location__exit(&al);
> - return ret;
> + return 0;
> }
>
> static int intel_pt_process_event(struct perf_session *session,