2023-06-19 15:27:22

by Michael Straube

Subject: [PATCH 0/4] staging: rtl8192e: some simple cleanups

Four patches with simple coding style cleanups.

Michael Straube (4):
staging: rtl8192e: clean up brace coding style issues
staging: rtl8192e: convert else if sequence to switch
staging: rtl8192e: remove return statement from void function
staging: rtl8192e: remove comparison to true

.../staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +-
.../staging/rtl8192e/rtl8192e/r8192E_phy.c | 11 +++---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 3 +-
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 3 +-
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 6 +--
drivers/staging/rtl8192e/rtllib_softmac.c | 39 +++++++++++--------
drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 +-
7 files changed, 40 insertions(+), 29 deletions(-)

--
2.41.0

2023-06-19 15:35:31

by Michael Straube

Subject: [PATCH 3/4] staging: rtl8192e: remove return statement from void function

Remove unnecessary return statement from the void function
rtl92e_config_mac(). Issue found by checkpatch.

WARNING: void function return statements are not generally useful

Signed-off-by: Michael Straube <[email protected]>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index 24180670ea0b..b0857c5709dd 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -268,7 +268,6 @@ void rtl92e_config_mac(struct net_device *dev)
rtl92e_set_bb_reg(dev, pdwArray[i], pdwArray[i + 1],
pdwArray[i + 2]);
}
- return;
}

static void _rtl92e_phy_config_bb(struct net_device *dev, u8 ConfigType)
--
2.41.0

2023-06-19 20:38:43

by Philipp Hortmann

Subject: Re: [PATCH 0/4] staging: rtl8192e: some simple cleanups

On 6/19/23 17:09, Michael Straube wrote:
> Four patches with simple coding style cleanups.
>
> Michael Straube (4):
> staging: rtl8192e: clean up brace coding style issues
> staging: rtl8192e: convert else if sequence to switch
> staging: rtl8192e: remove return statement from void function
> staging: rtl8192e: remove comparison to true
>
> .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +-
> .../staging/rtl8192e/rtl8192e/r8192E_phy.c | 11 +++---
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 3 +-
> drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 3 +-
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 6 +--
> drivers/staging/rtl8192e/rtllib_softmac.c | 39 +++++++++++--------
> drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 +-
> 7 files changed, 40 insertions(+), 29 deletions(-)
>
Tested-by: Philipp Hortmann <[email protected]>