2023-06-21 11:38:01

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH v2 0/4] A610 enablement, J606F display

Enable the A610 GPU on SM6115, as well as on the RB2 and J606F boards.
Add display support for the latter.

Signed-off-by: Konrad Dybcio <[email protected]>
---
Changes in v2:
- Fix pin naming and implicit override in patch 2
- Pick up tags
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Konrad Dybcio (4):
arm64: dts: qcom: sm6115: Add GPU nodes
arm64: dts: qcom: sm6115p-j606f: Hook up display
arm64: dts: qcom: sm6115p-j606f: Enable GPU
arm64: dts: qcom: qrb4210-rb2: Enable GPU

arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 8 ++
arch/arm64/boot/dts/qcom/sm6115.dtsi | 103 ++++++++++++++++++++++
arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 65 ++++++++++++--
3 files changed, 171 insertions(+), 5 deletions(-)
---
base-commit: 15e71592dbae49a674429c618a10401d7f992ac3
change-id: 20230620-topic-gpu_tablet_disp-cdc6ca5941c4

Best regards,
--
Konrad Dybcio <[email protected]>



2023-06-21 11:44:03

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH v2 3/4] arm64: dts: qcom: sm6115p-j606f: Enable GPU

Enable the A610 GPU and provide a firmware path to the ZAP blob.

Reviewed-by: Dmitry Baryshkov <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
index 667273ae0553..c2d15fc6c96b 100644
--- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
@@ -65,6 +65,14 @@ ramoops@ffc00000 {
};
};

+&gpu {
+ status = "okay";
+
+ zap-shader {
+ firmware-name = "qcom/sm6115/LENOVO/J606F/a610_zap.mbn";
+ };
+};
+
&mdss {
status = "okay";
};

--
2.41.0


2023-06-21 11:46:27

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH v2 4/4] arm64: dts: qcom: qrb4210-rb2: Enable GPU

Enable the A610 GPU and provide a firmware path to the ZAP blob.

Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
index e23a0406eacc..a7278a9472ed 100644
--- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
+++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
@@ -179,6 +179,14 @@ &gpi_dma0 {
status = "okay";
};

+&gpu {
+ status = "okay";
+
+ zap-shader {
+ firmware-name = "qcom/qrb4210/a610_zap.mbn";
+ };
+};
+
&i2c2 {
clock-frequency = <400000>;
status = "okay";

--
2.41.0


2023-06-21 11:49:52

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH v2 2/4] arm64: dts: qcom: sm6115p-j606f: Hook up display

Enable the required nodes, add the required pins and tweak a
regulator to enable non-simplefb display on the Tab P11.

Do note that there exists a second SKU with a different panel+touch
combo, but due to insufficient information, that will need to be
handled separately.

Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 57 +++++++++++++++++++++--
1 file changed, 52 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
index 81fdcaf48926..667273ae0553 100644
--- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
@@ -65,9 +65,41 @@ ramoops@ffc00000 {
};
};

-&dispcc {
- /* HACK: disable until a panel driver is ready to retain simplefb */
- status = "disabled";
+&mdss {
+ status = "okay";
+};
+
+&mdss_dsi0 {
+ vdda-supply = <&pm6125_l18>;
+ status = "okay";
+
+ panel: panel@0 {
+ compatible = "lenovo,j606f-boe-nt36523w", "novatek,nt36523w";
+ reg = <0>;
+
+ reset-gpios = <&tlmm 82 GPIO_ACTIVE_LOW>;
+ vddio-supply = <&pm6125_l9>;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&te_active &mdss_dsi_active>;
+
+ rotation = <180>; /* Yep, it's mounted upside down! */
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+ };
+};
+
+&mdss_dsi0_out {
+ data-lanes = <0 1 2 3>;
+ remote-endpoint = <&panel_in>;
+};
+
+&mdss_dsi0_phy {
+ status = "okay";
};

&pm6125_gpios {
@@ -212,8 +244,9 @@ pm6125_l17: l17 {
};

pm6125_l18: l18 {
- regulator-min-microvolt = <1104000>;
- regulator-max-microvolt = <1312000>;
+ /* 1.104V-1.312V fixed @ 1.232V for DSIPHY */
+ regulator-min-microvolt = <1232000>;
+ regulator-max-microvolt = <1232000>;
};

pm6125_l19: l19 {
@@ -282,6 +315,20 @@ sdc2_gate_pin: sdc2-gate-state {
bias-pull-up;
output-high;
};
+
+ te_active: te-active-state {
+ pins = "gpio81";
+ function = "mdp_vsync";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ mdss_dsi_active: dsi-active-state {
+ pins = "gpio82";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-disable;
+ };
};

&ufs_mem_hc {

--
2.41.0


2023-06-21 14:41:32

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: sm6115p-j606f: Hook up display

On Wed, 21 Jun 2023 at 14:22, Konrad Dybcio <[email protected]> wrote:
>
> Enable the required nodes, add the required pins and tweak a
> regulator to enable non-simplefb display on the Tab P11.
>
> Do note that there exists a second SKU with a different panel+touch
> combo, but due to insufficient information, that will need to be
> handled separately.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 57 +++++++++++++++++++++--
> 1 file changed, 52 insertions(+), 5 deletions(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2023-07-10 05:34:35

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] A610 enablement, J606F display


On Wed, 21 Jun 2023 13:21:51 +0200, Konrad Dybcio wrote:
> Enable the A610 GPU on SM6115, as well as on the RB2 and J606F boards.
> Add display support for the latter.
>
>

Applied, thanks!

[1/4] arm64: dts: qcom: sm6115: Add GPU nodes
commit: 11750af256f8287f853daed0424eac726dcc5b9f
[2/4] arm64: dts: qcom: sm6115p-j606f: Hook up display
commit: e3dc814d8ca0fb3c8e2760d004ea048e502887a4
[3/4] arm64: dts: qcom: sm6115p-j606f: Enable GPU
commit: be9f88abf8695b59f17ac0ef365cd2d2a9baae78
[4/4] arm64: dts: qcom: qrb4210-rb2: Enable GPU
commit: d368279dfa02c6c1eb5eb91126613769527d450b

Best regards,
--
Bjorn Andersson <[email protected]>