2023-06-18 13:28:48

by Rabara, Niravkumar L

Subject: [PATCH 1/4] dt-bindings: intel: Add Intel Agilex5 compatible

From: Niravkumar L Rabara <[email protected]>

Add new compatible for Intel Agilex5 based boards.

Signed-off-by: Niravkumar L Rabara <[email protected]>
---
Documentation/devicetree/bindings/arm/intel,socfpga.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
index 4b4dcf551eb6..28849c720314 100644
--- a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
+++ b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
@@ -20,6 +20,7 @@ properties:
- intel,n5x-socdk
- intel,socfpga-agilex-n6000
- intel,socfpga-agilex-socdk
+ - intel,socfpga-agilex5-socdk
- const: intel,socfpga-agilex

additionalProperties: true
--
2.25.1

2023-06-18 19:16:29

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/4] dt-bindings: intel: Add Intel Agilex5 compatible

On 18/06/2023 15:22, [email protected] wrote:
> From: Niravkumar L Rabara <[email protected]>
>
> Add new compatible for Intel Agilex5 based boards.
>
> Signed-off-by: Niravkumar L Rabara <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/intel,socfpga.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
> index 4b4dcf551eb6..28849c720314 100644
> --- a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
> +++ b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
> @@ -20,6 +20,7 @@ properties:
> - intel,n5x-socdk
> - intel,socfpga-agilex-n6000
> - intel,socfpga-agilex-socdk
> + - intel,socfpga-agilex5-socdk
> - const: intel,socfpga-agilex

This is agilex5, not agilex. Why are you using the same SoC compatible?
You have entire commit msg to explain your hardware and avoid such
questions...

Best regards,
Krzysztof

2023-06-20 14:40:32

by Rabara, Niravkumar L

Subject: Re: [PATCH 1/4] dt-bindings: intel: Add Intel Agilex5 compatible

>> diff --git a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>> b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>> index 4b4dcf551eb6..28849c720314 100644
>> --- a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>> +++ b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>> @@ -20,6 +20,7 @@ properties:
>> - intel,n5x-socdk
>> - intel,socfpga-agilex-n6000
>> - intel,socfpga-agilex-socdk
>> + - intel,socfpga-agilex5-socdk
>> - const: intel,socfpga-agilex
>
>This is agilex5, not agilex. Why are you using the same SoC compatible?
>You have entire commit msg to explain your hardware and avoid such questions...

Yes, better to use different SoC compatible for Agilex5,
will add new description and item for Agilex5 board in v2 patch.