2023-06-21 01:00:55

by Matthew Anderson

Subject: [PATCH 2/2] ALSA: hda/realtek: Add quirks for Asus ROG Ally handheld using CS35L41

V1 > V2 Fix indentation

Signed-off-by: Matthew Anderson <[email protected]>
---
sound/pci/hda/patch_realtek.c | 42 +++++++++++++++++------------------
1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b918b0046144..a413bdee7f63 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8445,33 +8445,33 @@ static const struct hda_fixup alc269_fixups[] = {
[ALC294_FIXUP_ASUS_ALLY_PINS] = {
.type = HDA_FIXUP_PINS,
.v.pins = (const struct hda_pintbl[]) {
- { 0x19, 0x03a11050 },
- { 0x1a, 0x03a11C30 },
- { 0x21, 0x03211420 },
- { }
- },
+ { 0x19, 0x03a11050 },
+ { 0x1a, 0x03a11C30 },
+ { 0x21, 0x03211420 },
+ { }
+ },
.chained = true,
.chain_id = ALC294_FIXUP_ASUS_ALLY_VERBS
},
[ALC294_FIXUP_ASUS_ALLY_VERBS] = {
.type = HDA_FIXUP_VERBS,
.v.verbs = (const struct hda_verb[]) {
- { 0x20, AC_VERB_SET_COEF_INDEX, 0x45 },
- { 0x20, AC_VERB_SET_PROC_COEF, 0x5089 },
- { 0x20, AC_VERB_SET_COEF_INDEX, 0x46 },
- { 0x20, AC_VERB_SET_PROC_COEF, 0x0004 },
- { 0x20, AC_VERB_SET_COEF_INDEX, 0x47 },
- { 0x20, AC_VERB_SET_PROC_COEF, 0xA47A },
- { 0x20, AC_VERB_SET_COEF_INDEX, 0x49 },
- { 0x20, AC_VERB_SET_PROC_COEF, 0x0049},
- { 0x20, AC_VERB_SET_COEF_INDEX, 0x4A },
- { 0x20, AC_VERB_SET_PROC_COEF, 0x201B },
- { 0x20, AC_VERB_SET_COEF_INDEX, 0x6B },
- { 0x20, AC_VERB_SET_PROC_COEF, 0x4278},
- { }
- },
- .chained = true,
- .chain_id = ALC294_FIXUP_ASUS_ALLY_SPEAKER
+ { 0x20, AC_VERB_SET_COEF_INDEX, 0x45 },
+ { 0x20, AC_VERB_SET_PROC_COEF, 0x5089 },
+ { 0x20, AC_VERB_SET_COEF_INDEX, 0x46 },
+ { 0x20, AC_VERB_SET_PROC_COEF, 0x0004 },
+ { 0x20, AC_VERB_SET_COEF_INDEX, 0x47 },
+ { 0x20, AC_VERB_SET_PROC_COEF, 0xA47A },
+ { 0x20, AC_VERB_SET_COEF_INDEX, 0x49 },
+ { 0x20, AC_VERB_SET_PROC_COEF, 0x0049},
+ { 0x20, AC_VERB_SET_COEF_INDEX, 0x4A },
+ { 0x20, AC_VERB_SET_PROC_COEF, 0x201B },
+ { 0x20, AC_VERB_SET_COEF_INDEX, 0x6B },
+ { 0x20, AC_VERB_SET_PROC_COEF, 0x4278},
+ { }
+ },
+ .chained = true,
+ .chain_id = ALC294_FIXUP_ASUS_ALLY_SPEAKER
},
[ALC294_FIXUP_ASUS_ALLY_SPEAKER] = {
.type = HDA_FIXUP_FUNC,
--
2.41.0

2023-06-21 06:06:14

by Takashi Iwai

Subject: Re: [PATCH 2/2] ALSA: hda/realtek: Add quirks for Asus ROG Ally handheld using CS35L41

On Wed, 21 Jun 2023 02:24:01 +0200,
Matthew Anderson wrote:
>
> V1 > V2 Fix indentation
>
> Signed-off-by: Matthew Anderson <[email protected]>

Could you rather fold into one and resubmit?

Also, do you have any reference to the bug tracker or whatever entry?


thanks,

Takashi