2023-06-21 08:43:09

by Matthew Anderson

Subject: [PATCH v3] ALSA: hda/realtek: Add quirks for ROG ALLY CS35l41 audio

Fixed the nitputs as requested

Signed-off-by: Matthew Anderson <[email protected]>
---
sound/pci/hda/patch_realtek.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a3981160b745..75f64131b369 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8446,7 +8446,7 @@ static const struct hda_fixup alc269_fixups[] = {
.type = HDA_FIXUP_PINS,
.v.pins = (const struct hda_pintbl[]) {
{ 0x19, 0x03a11050 },
- { 0x1a, 0x03a11C30 },
+ { 0x1a, 0x03a11c30 },
{ 0x21, 0x03211420 },
{ }
},
@@ -8461,12 +8461,12 @@ static const struct hda_fixup alc269_fixups[] = {
{ 0x20, AC_VERB_SET_COEF_INDEX, 0x46 },
{ 0x20, AC_VERB_SET_PROC_COEF, 0x0004 },
{ 0x20, AC_VERB_SET_COEF_INDEX, 0x47 },
- { 0x20, AC_VERB_SET_PROC_COEF, 0xA47A },
+ { 0x20, AC_VERB_SET_PROC_COEF, 0xa47a },
{ 0x20, AC_VERB_SET_COEF_INDEX, 0x49 },
{ 0x20, AC_VERB_SET_PROC_COEF, 0x0049},
- { 0x20, AC_VERB_SET_COEF_INDEX, 0x4A },
- { 0x20, AC_VERB_SET_PROC_COEF, 0x201B },
- { 0x20, AC_VERB_SET_COEF_INDEX, 0x6B },
+ { 0x20, AC_VERB_SET_COEF_INDEX, 0x4a },
+ { 0x20, AC_VERB_SET_PROC_COEF, 0x201b },
+ { 0x20, AC_VERB_SET_COEF_INDEX, 0x6b },
{ 0x20, AC_VERB_SET_PROC_COEF, 0x4278},
{ }
},
@@ -9579,6 +9579,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
SND_PCI_QUIRK(0x1043, 0x1740, "ASUS UX430UA", ALC295_FIXUP_ASUS_DACS),
SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_DUAL_SPK),
+ SND_PCI_QUIRK(0x1043, 0x17f3, "ROG Ally RC71L_RC71L", ALC294_FIXUP_ASUS_ALLY),
SND_PCI_QUIRK(0x1043, 0x1881, "ASUS Zephyrus S/M", ALC294_FIXUP_ASUS_GX502_PINS),
SND_PCI_QUIRK(0x1043, 0x18b1, "Asus MJ401TA", ALC256_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x18f1, "Asus FX505DT", ALC256_FIXUP_ASUS_HEADSET_MIC),
@@ -9641,7 +9642,6 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x10ec, 0x1254, "Intel Reference board", ALC295_FIXUP_CHROME_BOOK),
SND_PCI_QUIRK(0x10ec, 0x12cc, "Intel Reference board", ALC225_FIXUP_HEADSET_JACK),
SND_PCI_QUIRK(0x10f7, 0x8338, "Panasonic CF-SZ6", ALC269_FIXUP_HEADSET_MODE),
- SND_PCI_QUIRK(0x1043, 0x17F3, "ROG Ally RC71L_RC71L", ALC294_FIXUP_ASUS_ALLY),
SND_PCI_QUIRK(0x144d, 0xc109, "Samsung Ativ book 9 (NP900X3G)", ALC269_FIXUP_INV_DMIC),
SND_PCI_QUIRK(0x144d, 0xc169, "Samsung Notebook 9 Pen (NP930SBE-K01US)", ALC298_FIXUP_SAMSUNG_AMP),
SND_PCI_QUIRK(0x144d, 0xc176, "Samsung Notebook 9 Pro (NP930MBE-K04US)", ALC298_FIXUP_SAMSUNG_AMP),
--
2.41.0

2023-06-21 09:24:51

by Takashi Iwai

Subject: Re: [PATCH v3] ALSA: hda/realtek: Add quirks for ROG ALLY CS35l41 audio

On Wed, 21 Jun 2023 10:38:14 +0200,
Matthew Anderson wrote:
>
> Fixed the nitputs as requested
>
> Signed-off-by: Matthew Anderson <[email protected]>

Again, please fold your change. I haven't merged your previous
patch, after all.


Takashi