2023-06-21 08:22:32

by Baolin Wang

Subject: [PATCH] mm: page_alloc: use the correct type of list for free pages

Commit bf75f200569d ("mm/page_alloc: add page->buddy_list and page->pcp_list")
introduces page->buddy_list and page->pcp_list as a union with page->lru, but
missed to change get_page_from_free_area() to use page->buddy_list to clarify
the correct type of list for a free page.

Signed-off-by: Baolin Wang <[email protected]>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 5c691426822a..c1839a53326c 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -727,7 +727,7 @@ static inline struct page *get_page_from_free_area(struct free_area *area,
int migratetype)
{
return list_first_entry_or_null(&area->free_list[migratetype],
- struct page, lru);
+ struct page, buddy_list);
}

/*
--
2.27.0

2023-06-21 11:12:08

by Mel Gorman

Subject: Re: [PATCH] mm: page_alloc: use the correct type of list for free pages

On Wed, Jun 21, 2023 at 04:14:28PM +0800, Baolin Wang wrote:
> Commit bf75f200569d ("mm/page_alloc: add page->buddy_list and page->pcp_list")
> introduces page->buddy_list and page->pcp_list as a union with page->lru, but
> missed to change get_page_from_free_area() to use page->buddy_list to clarify
> the correct type of list for a free page.
>
> Signed-off-by: Baolin Wang <[email protected]>

Acked-by: Mel Gorman <[email protected]>

--
Mel Gorman
SUSE Labs

2023-06-21 11:45:00

by David Hildenbrand

Subject: Re: [PATCH] mm: page_alloc: use the correct type of list for free pages

On 21.06.23 10:14, Baolin Wang wrote:
> Commit bf75f200569d ("mm/page_alloc: add page->buddy_list and page->pcp_list")
> introduces page->buddy_list and page->pcp_list as a union with page->lru, but
> missed to change get_page_from_free_area() to use page->buddy_list to clarify
> the correct type of list for a free page.
>
> Signed-off-by: Baolin Wang <[email protected]>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 5c691426822a..c1839a53326c 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -727,7 +727,7 @@ static inline struct page *get_page_from_free_area(struct free_area *area,
> int migratetype)
> {
> return list_first_entry_or_null(&area->free_list[migratetype],
> - struct page, lru);
> + struct page, buddy_list);
> }
>
> /*

Reviewed-by: David Hildenbrand <[email protected]>

--
Cheers,

David / dhildenb