2023-06-21 12:05:25

by Valentin Caron

[permalink] [raw]
Subject: [PATCH 0/2] spi: stm32: disable spi device mode for stm32f4-f7

This series follows this thread:
https://lore.kernel.org/all/[email protected]/

As STM32F4-F7 hardware can handle device mode and stm32 spi kernel
driver can't, a restriction should be put in the kernel driver and
not in the device-tree bindings. This series fixes that.

Valentin Caron (2):
spi: stm32: disable device mode with st,stm32f4-spi compatible
spi: dt-bindings: stm32: do not disable spi-slave property for
stm32f4-f7

.../devicetree/bindings/spi/st,stm32-spi.yaml | 1 -
drivers/spi/spi-stm32.c | 15 ++++++++++++---
2 files changed, 12 insertions(+), 4 deletions(-)

--
2.25.1



2023-06-21 12:14:59

by Valentin Caron

[permalink] [raw]
Subject: [PATCH 2/2] spi: dt-bindings: stm32: do not disable spi-slave property for stm32f4-f7

STM32F4-F7 are, from hardware point of view, capable to handle device mode.
So this property should not be forced at false in dt-bindings.

Signed-off-by: Valentin Caron <[email protected]>
---
Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 1 -
1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
index f1c86e694af1..9ca1a843c820 100644
--- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
@@ -27,7 +27,6 @@ allOf:
then:
properties:
st,spi-midi-ns: false
- spi-slave: false

properties:
compatible:
--
2.25.1


2023-06-21 13:13:13

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] spi: dt-bindings: stm32: do not disable spi-slave property for stm32f4-f7

On 21/06/2023 13:55, Valentin Caron wrote:
> STM32F4-F7 are, from hardware point of view, capable to handle device mode.
> So this property should not be forced at false in dt-bindings.
>
> Signed-off-by: Valentin Caron <[email protected]>

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2023-06-23 00:53:34

by Mark Brown

[permalink] [raw]
Subject: Re: (subset) [PATCH 0/2] spi: stm32: disable spi device mode for stm32f4-f7

On Wed, 21 Jun 2023 13:55:21 +0200, Valentin Caron wrote:
> This series follows this thread:
> https://lore.kernel.org/all/[email protected]/
>
> As STM32F4-F7 hardware can handle device mode and stm32 spi kernel
> driver can't, a restriction should be put in the kernel driver and
> not in the device-tree bindings. This series fixes that.
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[2/2] spi: dt-bindings: stm32: do not disable spi-slave property for stm32f4-f7
commit: 01fa9edd8bcf1c4fe330ea000c3da9ecf76c76a0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark