2023-06-21 14:03:53

by Sumit Gupta

Subject: [Patch RESEND 0/4] Tegra234 Memory Interconnect followup changes

This patch set adds VIC, NVDEC, NVENC, NVJPG, NVDISPLAY clients
of Memory Controller to the Tegra234 MC clients table. It also
improves error handling when some MRQ's are not supported by a
platform. For Example:
- Avoid "tegra186_emc_probe" failure if the "MRQ_EMC_DVFS_LATENCY"
is not supported.
- Avoid Error returned by icc_set_bw() in the MC client drivers if
the "MRQ_BWMGR_INT" is not supported.

Sumit Gupta (4):
memory: tegra: sort tegra234_mc_clients table as per register offsets
memory: tegra: Add clients used by DRM in Tegra234
memory: tegra: add check if MRQ_EMC_DVFS_LATENCY is supported
memory: tegra: make icc_set_bw return zero if BWMGR not supported

drivers/memory/tegra/tegra186-emc.c | 136 ++++---
drivers/memory/tegra/tegra234.c | 604 +++++++++++++++++-----------
2 files changed, 435 insertions(+), 305 deletions(-)

--
2.17.1

2023-07-14 04:26:11

by Krzysztof Kozlowski

Subject: Re: [Patch RESEND 0/4] Tegra234 Memory Interconnect followup changes

On Wed, 21 Jun 2023 19:13:56 +0530, Sumit Gupta wrote:
> This patch set adds VIC, NVDEC, NVENC, NVJPG, NVDISPLAY clients
> of Memory Controller to the Tegra234 MC clients table. It also
> improves error handling when some MRQ's are not supported by a
> platform. For Example:
> - Avoid "tegra186_emc_probe" failure if the "MRQ_EMC_DVFS_LATENCY"
> is not supported.
> - Avoid Error returned by icc_set_bw() in the MC client drivers if
> the "MRQ_BWMGR_INT" is not supported.
>
> [...]

Applied, thanks!

[1/4] memory: tegra: sort tegra234_mc_clients table as per register offsets
https://git.kernel.org/krzk/linux-mem-ctrl/c/01c70c8e52c5579de0c3fff81f81778a570a8643
[2/4] memory: tegra: Add clients used by DRM in Tegra234
https://git.kernel.org/krzk/linux-mem-ctrl/c/9d0bd0e535953886cd1a1335941c5afbe4d7df32
[3/4] memory: tegra: add check if MRQ_EMC_DVFS_LATENCY is supported
https://git.kernel.org/krzk/linux-mem-ctrl/c/8fda1018ca68e7b8fa860087e3069c3be476148f

Checkpatch errors (I guess expected due to code move):
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#86: FILE: drivers/memory/tegra/tegra186-emc.c:215:
+ debugfs_create_file("available_rates", S_IRUGO, emc->debugfs.root,

WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
#88: FILE: drivers/memory/tegra/tegra186-emc.c:217:
+ debugfs_create_file("min_rate", S_IRUGO | S_IWUSR, emc->debugfs.root,

WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
#90: FILE: drivers/memory/tegra/tegra186-emc.c:219:
+ debugfs_create_file("max_rate", S_IRUGO | S_IWUSR, emc->debugfs.root,


[4/4] memory: tegra: make icc_set_bw return zero if BWMGR not supported
https://git.kernel.org/krzk/linux-mem-ctrl/c/3d7cfb8d6142c1d681eb70eae7fb1950b59fc0dc

Best regards,
--
Krzysztof Kozlowski <[email protected]>