When user_events are disabled, it's write operation should return zero.
Add this test cases.
Signed-off-by: sunliming <[email protected]>
---
tools/testing/selftests/user_events/ftrace_test.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c
index d33bd31425db..7968d69c3a5c 100644
--- a/tools/testing/selftests/user_events/ftrace_test.c
+++ b/tools/testing/selftests/user_events/ftrace_test.c
@@ -297,6 +297,9 @@ TEST_F(user, write_events) {
io[0].iov_base = ®.write_index;
io[0].iov_len = sizeof(reg.write_index);
+ /* Write should return zero when event is not enabled */
+ ASSERT_EQ(0, writev(self->data_fd, (const struct iovec *)io, 3));
+
/* Enable event */
self->enable_fd = open(enable_file, O_RDWR);
ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1")))
--
2.25.1
On Thu, 22 Jun 2023 20:27:40 +0000
Beau Belgrave <[email protected]> wrote:
> On Wed, Jun 21, 2023 at 02:35:02PM +0800, sunliming wrote:
> > When user_events are disabled, it's write operation should return zero.
> > Add this test cases.
> >
> > Signed-off-by: sunliming <[email protected]>
>
> I don't have a problem with the chagne to the test, however, the patch
> title has a typo in it for "disabled" that should be corrected. I've
> ACK'd the other 2 patches, so you only need to resubmit this one with a
> correct title.
Ah, I misunderstood when we talked earlier today. I thought the typo was in
the text of the start selftest. That is, it was part of the patch.
For a typo in the subject, I can make that fix when I pulled it in. I just
avoid touching content of the patch itself.
Care to ack it?
Thanks!
-- Steve
On Wed, Jun 21, 2023 at 02:35:02PM +0800, sunliming wrote:
> When user_events are disabled, it's write operation should return zero.
> Add this test cases.
>
> Signed-off-by: sunliming <[email protected]>
I don't have a problem with the chagne to the test, however, the patch
title has a typo in it for "disabled" that should be corrected. I've
ACK'd the other 2 patches, so you only need to resubmit this one with a
correct title.
Thanks,
-Beau
> ---
> tools/testing/selftests/user_events/ftrace_test.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/user_events/ftrace_test.c b/tools/testing/selftests/user_events/ftrace_test.c
> index d33bd31425db..7968d69c3a5c 100644
> --- a/tools/testing/selftests/user_events/ftrace_test.c
> +++ b/tools/testing/selftests/user_events/ftrace_test.c
> @@ -297,6 +297,9 @@ TEST_F(user, write_events) {
> io[0].iov_base = ®.write_index;
> io[0].iov_len = sizeof(reg.write_index);
>
> + /* Write should return zero when event is not enabled */
> + ASSERT_EQ(0, writev(self->data_fd, (const struct iovec *)io, 3));
> +
> /* Enable event */
> self->enable_fd = open(enable_file, O_RDWR);
> ASSERT_NE(-1, write(self->enable_fd, "1", sizeof("1")))
> --
> 2.25.1
On Thu, Jun 22, 2023 at 04:30:36PM -0400, Steven Rostedt wrote:
> On Thu, 22 Jun 2023 20:27:40 +0000
> Beau Belgrave <[email protected]> wrote:
>
> > On Wed, Jun 21, 2023 at 02:35:02PM +0800, sunliming wrote:
> > > When user_events are disabled, it's write operation should return zero.
> > > Add this test cases.
> > >
> > > Signed-off-by: sunliming <[email protected]>
> >
> > I don't have a problem with the chagne to the test, however, the patch
> > title has a typo in it for "disabled" that should be corrected. I've
> > ACK'd the other 2 patches, so you only need to resubmit this one with a
> > correct title.
>
> Ah, I misunderstood when we talked earlier today. I thought the typo was in
> the text of the start selftest. That is, it was part of the patch.
>
> For a typo in the subject, I can make that fix when I pulled it in. I just
> avoid touching content of the patch itself.
>
Great, thanks!
> Care to ack it?
>
Sure thing:
Acked-by: Beau Belgrave <[email protected]>
Thanks,
-Beau
> Thanks!
>
> -- Steve