2023-06-14 09:15:56

by Lukas Bulwahn

Subject: [PATCH] MAINTAINERS: repair pattern in ARM/Amlogic Meson SoC CLOCK FRAMEWORK

Commit e6c6ddb397e2 ("dt-bindings: clock: meson: add A1 PLL clock
controller bindings") adds a file entry with pattern
"include/dt-bindings/clock/a1*" to the ARM/Amlogic Meson SoC CLOCK
FRAMEWORK section. However, all header files added in the patch series to
add Amlogic A1 clock controller drivers carry the prefix "amlogic,a1", and
there are not header files matching "a1*".

Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
broken reference.

Adjust the pattern of this file entry to match the headers actually added.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 08c7efe271c3..08f7c69c67c4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1887,7 +1887,7 @@ L: [email protected]
S: Maintained
F: Documentation/devicetree/bindings/clock/amlogic*
F: drivers/clk/meson/
-F: include/dt-bindings/clock/a1*
+F: include/dt-bindings/clock/amlogic,a1*
F: include/dt-bindings/clock/gxbb*
F: include/dt-bindings/clock/meson*

--
2.17.1

2023-06-15 10:40:56

by Jerome Brunet

Subject: Re: [PATCH] MAINTAINERS: repair pattern in ARM/Amlogic Meson SoC CLOCK FRAMEWORK

On Wed 14 Jun 2023 at 10:42, Lukas Bulwahn <[email protected]> wrote:

> Commit e6c6ddb397e2 ("dt-bindings: clock: meson: add A1 PLL clock
> controller bindings") adds a file entry with pattern
> "include/dt-bindings/clock/a1*" to the ARM/Amlogic Meson SoC CLOCK
> FRAMEWORK section. However, all header files added in the patch series to
> add Amlogic A1 clock controller drivers carry the prefix "amlogic,a1", and
> there are not header files matching "a1*".
>
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> broken reference.
>
> Adjust the pattern of this file entry to match the headers actually added.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>

Added fix tag:
Fixes: e6c6ddb397e2 ("dt-bindings: clock: meson: add A1 PLL clock controller bindings")

and applied through the amlogic clock tree.
Thx

> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 08c7efe271c3..08f7c69c67c4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1887,7 +1887,7 @@ L: [email protected]
> S: Maintained
> F: Documentation/devicetree/bindings/clock/amlogic*
> F: drivers/clk/meson/
> -F: include/dt-bindings/clock/a1*
> +F: include/dt-bindings/clock/amlogic,a1*
> F: include/dt-bindings/clock/gxbb*
> F: include/dt-bindings/clock/meson*

2023-06-22 20:34:29

by Dmitry Rokosov

Subject: Re: [PATCH] MAINTAINERS: repair pattern in ARM/Amlogic Meson SoC CLOCK FRAMEWORK

Dear Lukas,

I want to express my sincere gratitude for promptly correcting my
mistake. Your help is truly appreciated. Thank you very much!

On Wed, Jun 14, 2023 at 10:42:12AM +0200, Lukas Bulwahn wrote:
> Commit e6c6ddb397e2 ("dt-bindings: clock: meson: add A1 PLL clock
> controller bindings") adds a file entry with pattern
> "include/dt-bindings/clock/a1*" to the ARM/Amlogic Meson SoC CLOCK
> FRAMEWORK section. However, all header files added in the patch series to
> add Amlogic A1 clock controller drivers carry the prefix "amlogic,a1", and
> there are not header files matching "a1*".
>
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> broken reference.
>
> Adjust the pattern of this file entry to match the headers actually added.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 08c7efe271c3..08f7c69c67c4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1887,7 +1887,7 @@ L: [email protected]
> S: Maintained
> F: Documentation/devicetree/bindings/clock/amlogic*
> F: drivers/clk/meson/
> -F: include/dt-bindings/clock/a1*
> +F: include/dt-bindings/clock/amlogic,a1*
> F: include/dt-bindings/clock/gxbb*
> F: include/dt-bindings/clock/meson*
>

Reviewed-by: Dmitry Rokosov <[email protected]>

> --
> 2.17.1
>

--
Thank you,
Dmitry