2023-06-23 07:49:06

by Radu Pirea (NXP OSS)

Subject: [PATCH v2 05/13] net: phy: c45: detect 100BaseT1 and 1000BaseT1 PMA abilites

Detect 100BaseT1 and 1000BaseT1 PMA abilites using dedicated bits.

Signed-off-by: Radu Pirea (NXP OSS) <[email protected]>
---
drivers/net/phy/phy-c45.c | 8 ++++++++
include/uapi/linux/mdio.h | 2 ++
2 files changed, 10 insertions(+)

diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c
index fee514b96ab1..1017aeb0599b 100644
--- a/drivers/net/phy/phy-c45.c
+++ b/drivers/net/phy/phy-c45.c
@@ -976,6 +976,14 @@ int genphy_c45_pma_read_abilities(struct phy_device *phydev)
phydev->supported,
val & MDIO_PMA_PMD_BT1_B10L_ABLE);

+ linkmode_mod_bit(ETHTOOL_LINK_MODE_100baseT1_Full_BIT,
+ phydev->supported,
+ val & MDIO_PMA_PMD_BT1_B100_ABLE);
+
+ linkmode_mod_bit(ETHTOOL_LINK_MODE_1000baseT1_Full_BIT,
+ phydev->supported,
+ val & MDIO_PMA_PMD_BT1_B1000_ABLE);
+
val = phy_read_mmd(phydev, MDIO_MMD_AN, MDIO_AN_T1_STAT);
if (val < 0)
return val;
diff --git a/include/uapi/linux/mdio.h b/include/uapi/linux/mdio.h
index b826598d1e94..82ed363f5268 100644
--- a/include/uapi/linux/mdio.h
+++ b/include/uapi/linux/mdio.h
@@ -332,6 +332,8 @@
#define MDIO_PCS_10T1L_CTRL_RESET 0x8000 /* PCS reset */

/* BASE-T1 PMA/PMD extended ability register. */
+#define MDIO_PMA_PMD_BT1_B100_ABLE 0x0001 /* 100BASE-T1 Ability */
+#define MDIO_PMA_PMD_BT1_B1000_ABLE 0x0002 /* 1000BASE-T1 Ability */
#define MDIO_PMA_PMD_BT1_B10L_ABLE 0x0004 /* 10BASE-T1L Ability */

/* BASE-T1 auto-negotiation advertisement register [15:0] */
--
2.34.1

2023-06-24 19:09:58

by Andrew Lunn

Subject: Re: [PATCH v2 05/13] net: phy: c45: detect 100BaseT1 and 1000BaseT1 PMA abilites

On Fri, Jun 23, 2023 at 10:41:15AM +0300, Radu Pirea (NXP OSS) wrote:
> Detect 100BaseT1 and 1000BaseT1 PMA abilites using dedicated bits.
>
> Signed-off-by: Radu Pirea (NXP OSS) <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew