2023-06-23 08:21:26

by Lucas Tanure

Subject: [PATCH v5 1/4] dt-bindings: arm: amlogic: add Amlogic A311D2 bindings

Add bindings for the Khadas Vim4 board, using A311D2 soc, a Meson T7
family chip.

Signed-off-by: Lucas Tanure <[email protected]>
Acked-by: Conor Dooley <[email protected]>
---
Documentation/devicetree/bindings/arm/amlogic.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
index 274ee0890312..8dbd65170c50 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.yaml
+++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
@@ -211,6 +211,13 @@ properties:
- amlogic,aq222
- const: amlogic,s4

+ - description: Boards with the Amlogic Meson t7 A311D2 SoC
+ items:
+ - enum:
+ - khadas,vim4
+ - const: amlogic,a311d2
+ - const: amlogic,t7
+
additionalProperties: true

...
--
2.41.0

2023-06-25 10:54:16

by Kelvin Zhang

Subject: Re: [PATCH v5 1/4] dt-bindings: arm: amlogic: add Amlogic A311D2 bindings

> Add bindings for the Khadas Vim4 board, using A311D2 soc, a Meson T7
> family chip.
>
> Signed-off-by: Lucas Tanure <[email protected]>
> Acked-by: Conor Dooley <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 274ee0890312..8dbd65170c50 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -211,6 +211,13 @@ properties:
> - amlogic,aq222
> - const: amlogic,s4
>
> + - description: Boards with the Amlogic Meson t7 A311D2 SoC

Lucas,
Based on the previous discussion, I strongly suggest dropping "Meson".
T7 is designed for smart display, which does not belong to old Meson series.
You can refer to S4.
Also, t7 -> T7.
Thanks!

> + items:
> + - enum:
> + - khadas,vim4
> + - const: amlogic,a311d2
> + - const: amlogic,t7
> +
> additionalProperties: true
>
> ...
> --
> 2.41.0
>
>
> _______________________________________________
> linux-amlogic mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-amlogic