2023-06-23 09:36:35

by Yue Haibing

Subject: [PATCH -next] x86/ftrace: Remove unsued extern declaration ftrace_regs_caller_ret()

This is now unused, so can remove it.

Signed-off-by: YueHaibing <[email protected]>
---
arch/x86/kernel/ftrace.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
index 01e8f34daf22..12df54ff0e81 100644
--- a/arch/x86/kernel/ftrace.c
+++ b/arch/x86/kernel/ftrace.c
@@ -282,7 +282,6 @@ static inline void tramp_free(void *tramp) { }

/* Defined as markers to the end of the ftrace default trampolines */
extern void ftrace_regs_caller_end(void);
-extern void ftrace_regs_caller_ret(void);
extern void ftrace_caller_end(void);
extern void ftrace_caller_op_ptr(void);
extern void ftrace_regs_caller_op_ptr(void);
--
2.34.1

2023-06-25 06:26:35

by Masami Hiramatsu (Google)

Subject: Re: [PATCH -next] x86/ftrace: Remove unsued extern declaration ftrace_regs_caller_ret()

On Fri, 23 Jun 2023 17:16:40 +0800
YueHaibing <[email protected]> wrote:

> This is now unused, so can remove it.
>

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <[email protected]>

Thanks!

> Signed-off-by: YueHaibing <[email protected]>
> ---
> arch/x86/kernel/ftrace.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> index 01e8f34daf22..12df54ff0e81 100644
> --- a/arch/x86/kernel/ftrace.c
> +++ b/arch/x86/kernel/ftrace.c
> @@ -282,7 +282,6 @@ static inline void tramp_free(void *tramp) { }
>
> /* Defined as markers to the end of the ftrace default trampolines */
> extern void ftrace_regs_caller_end(void);
> -extern void ftrace_regs_caller_ret(void);
> extern void ftrace_caller_end(void);
> extern void ftrace_caller_op_ptr(void);
> extern void ftrace_regs_caller_op_ptr(void);
> --
> 2.34.1
>


--
Masami Hiramatsu (Google) <[email protected]>