2023-06-23 16:44:51

by Andrew Halaney

Subject: [PATCH] cpufreq: qcom-cpufreq-hw: Use dev_err_probe() when failing to get icc paths

This way, if there's an issue (in this case a -EPROBE_DEFER), you can
get useful output:

[root@dhcp19-243-150 ~]# cat /sys/kernel/debug/devices_deferred
18591000.cpufreq qcom-cpufreq-hw: Failed to find icc paths

Signed-off-by: Andrew Halaney <[email protected]>
---
drivers/cpufreq/qcom-cpufreq-hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
index a78d7a27b4b5..f2830371d25f 100644
--- a/drivers/cpufreq/qcom-cpufreq-hw.c
+++ b/drivers/cpufreq/qcom-cpufreq-hw.c
@@ -661,7 +661,7 @@ static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev)

ret = dev_pm_opp_of_find_icc_paths(cpu_dev, NULL);
if (ret)
- return ret;
+ return dev_err_probe(dev, ret, "Failed to find icc paths\n");

for (num_domains = 0; num_domains < MAX_FREQ_DOMAINS; num_domains++)
if (!platform_get_resource(pdev, IORESOURCE_MEM, num_domains))
--
2.40.1

2023-06-23 18:33:34

by Bjorn Andersson

Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Use dev_err_probe() when failing to get icc paths

On Fri, Jun 23, 2023 at 10:57:07AM -0500, Andrew Halaney wrote:
> This way, if there's an issue (in this case a -EPROBE_DEFER), you can
> get useful output:
>
> [root@dhcp19-243-150 ~]# cat /sys/kernel/debug/devices_deferred
> 18591000.cpufreq qcom-cpufreq-hw: Failed to find icc paths
>
> Signed-off-by: Andrew Halaney <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> drivers/cpufreq/qcom-cpufreq-hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
> index a78d7a27b4b5..f2830371d25f 100644
> --- a/drivers/cpufreq/qcom-cpufreq-hw.c
> +++ b/drivers/cpufreq/qcom-cpufreq-hw.c
> @@ -661,7 +661,7 @@ static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev)
>
> ret = dev_pm_opp_of_find_icc_paths(cpu_dev, NULL);
> if (ret)
> - return ret;
> + return dev_err_probe(dev, ret, "Failed to find icc paths\n");
>
> for (num_domains = 0; num_domains < MAX_FREQ_DOMAINS; num_domains++)
> if (!platform_get_resource(pdev, IORESOURCE_MEM, num_domains))
> --
> 2.40.1
>

2023-06-26 06:48:29

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Use dev_err_probe() when failing to get icc paths

On 23-06-23, 10:08, Bjorn Andersson wrote:
> On Fri, Jun 23, 2023 at 10:57:07AM -0500, Andrew Halaney wrote:
> > This way, if there's an issue (in this case a -EPROBE_DEFER), you can
> > get useful output:
> >
> > [root@dhcp19-243-150 ~]# cat /sys/kernel/debug/devices_deferred
> > 18591000.cpufreq qcom-cpufreq-hw: Failed to find icc paths
> >
> > Signed-off-by: Andrew Halaney <[email protected]>
>
> Reviewed-by: Bjorn Andersson <[email protected]>

Applied. Thanks.

--
viresh