2023-06-07 21:22:23

by Wolfram Sang

[permalink] [raw]
Subject: [PATCH v2] PCI: rcar: use proper naming for R-Car

Neither RCar, nor Rcar, but R-Car.

Signed-off-by: Wolfram Sang <[email protected]>
---

Change since V1:
* fix typo in $subject (Thanks, Biju!)

drivers/pci/controller/pcie-rcar-host.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c
index e80e56b2a842..f4dac8ff97cb 100644
--- a/drivers/pci/controller/pcie-rcar-host.c
+++ b/drivers/pci/controller/pcie-rcar-host.c
@@ -684,7 +684,7 @@ static void rcar_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
}

static struct irq_chip rcar_msi_bottom_chip = {
- .name = "Rcar MSI",
+ .name = "R-Car MSI",
.irq_ack = rcar_msi_irq_ack,
.irq_mask = rcar_msi_irq_mask,
.irq_unmask = rcar_msi_irq_unmask,
@@ -813,7 +813,7 @@ static int rcar_pcie_enable_msi(struct rcar_pcie_host *host)

/*
* Setup MSI data target using RC base address address, which
- * is guaranteed to be in the low 32bit range on any RCar HW.
+ * is guaranteed to be in the low 32bit range on any R-Car HW.
*/
rcar_pci_write_reg(pcie, lower_32_bits(res.start) | MSIFE, PCIEMSIALR);
rcar_pci_write_reg(pcie, upper_32_bits(res.start), PCIEMSIAUR);
--
2.35.1



2023-06-08 07:11:38

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH v2] PCI: rcar: use proper naming for R-Car

On Wed, Jun 7, 2023 at 10:49 PM Wolfram Sang
<[email protected]> wrote:
> Neither RCar, nor Rcar, but R-Car.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
>
> Change since V1:
> * fix typo in $subject (Thanks, Biju!)

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2023-06-08 09:14:27

by Yoshihiro Shimoda

[permalink] [raw]
Subject: RE: [PATCH v2] PCI: rcar: use proper naming for R-Car

Hello Wolfram-san,

> From: Wolfram Sang, Sent: Thursday, June 8, 2023 5:48 AM
>
> Neither RCar, nor Rcar, but R-Car.
>
> Signed-off-by: Wolfram Sang <[email protected]>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <[email protected]>

Best regards,
Yoshihiro Shimoda

> ---
>
> Change since V1:
> * fix typo in $subject (Thanks, Biju!)
>
> drivers/pci/controller/pcie-rcar-host.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c
> index e80e56b2a842..f4dac8ff97cb 100644
> --- a/drivers/pci/controller/pcie-rcar-host.c
> +++ b/drivers/pci/controller/pcie-rcar-host.c
> @@ -684,7 +684,7 @@ static void rcar_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
> }
>
> static struct irq_chip rcar_msi_bottom_chip = {
> - .name = "Rcar MSI",
> + .name = "R-Car MSI",
> .irq_ack = rcar_msi_irq_ack,
> .irq_mask = rcar_msi_irq_mask,
> .irq_unmask = rcar_msi_irq_unmask,
> @@ -813,7 +813,7 @@ static int rcar_pcie_enable_msi(struct rcar_pcie_host *host)
>
> /*
> * Setup MSI data target using RC base address address, which
> - * is guaranteed to be in the low 32bit range on any RCar HW.
> + * is guaranteed to be in the low 32bit range on any R-Car HW.
> */
> rcar_pci_write_reg(pcie, lower_32_bits(res.start) | MSIFE, PCIEMSIALR);
> rcar_pci_write_reg(pcie, upper_32_bits(res.start), PCIEMSIAUR);
> --
> 2.35.1


2023-06-24 13:38:57

by Krzysztof Wilczyński

[permalink] [raw]
Subject: Re: [PATCH v2] PCI: rcar: use proper naming for R-Car

Hello,

> Neither RCar, nor Rcar, but R-Car.

Applied to controller/rcar, thank you!

[1/1] PCI: rcar: Use correct product family name for Renesas R-Car
https://git.kernel.org/pci/pci/c/e28e75e9f589

Krzysztof

2023-06-26 16:13:34

by Krzysztof Wilczyński

[permalink] [raw]
Subject: Re: [PATCH v2] PCI: rcar: use proper naming for R-Car

Hello,

> > Neither RCar, nor Rcar, but R-Car.

There might be one more variance left to correct:

drivers/gpu/drm/rcar-du/rcar_du_plane.h:

18-/*
19: * The RCAR DU has 8 hardware planes, shared between primary and overlay planes.
20- * As using overlay planes requires at least one of the CRTCs being enabled, no
21- * more than 7 overlay planes can be available. We thus create 1 primary plane
22- * per CRTC and 7 overlay planes, for a total of up to 9 KMS planes.
23- */

For the sake of completeness.

Krzysztof