2023-06-25 04:16:43

by Miaohe Lin

Subject: [PATCH] mm/mm_init.c: Update obsolete comment in get_pfn_range_for_nid()

Since commit 633c0666b5a5 ("Memoryless nodes: drop one memoryless node boot
warning"), the warning for a node with no available memory is removed.
Update the corresponding comment.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/mm_init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/mm_init.c b/mm/mm_init.c
index 999723dee8cc..f90db54e2b21 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -1681,8 +1681,7 @@ static inline void alloc_node_mem_map(struct pglist_data *pgdat) { }
*
* It returns the start and end page frame of a node based on information
* provided by memblock_set_node(). If called for a node
- * with no available memory, a warning is printed and the start and end
- * PFNs will be 0.
+ * with no available memory, the start and end PFNs will be 0.
*/
void __init get_pfn_range_for_nid(unsigned int nid,
unsigned long *start_pfn, unsigned long *end_pfn)
--
2.27.0

2023-06-25 05:46:22

by Mike Rapoport

Subject: Re: [PATCH] mm/mm_init.c: Update obsolete comment in get_pfn_range_for_nid()

On Sun, Jun 25, 2023 at 11:33:40AM +0800, Miaohe Lin wrote:
> Since commit 633c0666b5a5 ("Memoryless nodes: drop one memoryless node boot
> warning"), the warning for a node with no available memory is removed.
> Update the corresponding comment.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Mike Rapoport (IBM) <[email protected]>

> ---
> mm/mm_init.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 999723dee8cc..f90db54e2b21 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1681,8 +1681,7 @@ static inline void alloc_node_mem_map(struct pglist_data *pgdat) { }
> *
> * It returns the start and end page frame of a node based on information
> * provided by memblock_set_node(). If called for a node
> - * with no available memory, a warning is printed and the start and end
> - * PFNs will be 0.
> + * with no available memory, the start and end PFNs will be 0.
> */
> void __init get_pfn_range_for_nid(unsigned int nid,
> unsigned long *start_pfn, unsigned long *end_pfn)
> --
> 2.27.0
>

--
Sincerely yours,
Mike.