2023-06-26 20:02:19

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 0/7] random msm bindings fixes

Signed-off-by: Konrad Dybcio <[email protected]>
---
Konrad Dybcio (7):
dt-bindings: qcom: Allow SoC names ending in "pro"
dt-bindings: remoteproc: qcom,msm8996-mss-pil: Fix 8996 clocks
arm64: dts: qcom: pm6150l: Add missing short interrupt
arm64: dts: qcom: pm660l: Add missing short interrupt
arm64: dts: qcom: pmi8950: Add missing OVP interrupt
arm64: dts: qcom: pmi8994: Add missing OVP interrupt
arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3

Documentation/devicetree/bindings/arm/qcom-soc.yaml | 2 +-
.../devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml | 7 +++----
arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
arch/arm64/boot/dts/qcom/pm660l.dtsi | 5 +++--
arch/arm64/boot/dts/qcom/pmi8950.dtsi | 5 +++--
arch/arm64/boot/dts/qcom/pmi8994.dtsi | 5 +++--
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 1 +
7 files changed, 17 insertions(+), 13 deletions(-)
---
base-commit: 3eedd211ad93c322fb360b83a3d76a2c6cd622dc
change-id: 20230626-topic-bindingsfixups-93d737dbf054

Best regards,
--
Konrad Dybcio <[email protected]>



2023-06-26 20:08:34

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 6/7] arm64: dts: qcom: pmi8994: Add missing OVP interrupt

Add the missing OVP interrupt. This fixes the schema warning:

wled@d800: interrupt-names: ['short'] is too short

Fixes: 37aa540cbd30 ("arm64: dts: qcom: pmi8994: Add WLED node")
Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/pmi8994.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
index 0192968f4d9b..36d6a1fb553a 100644
--- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
@@ -54,8 +54,9 @@ pmi8994_spmi_regulators: regulators {
pmi8994_wled: wled@d800 {
compatible = "qcom,pmi8994-wled";
reg = <0xd800>, <0xd900>;
- interrupts = <3 0xd8 0x02 IRQ_TYPE_EDGE_RISING>;
- interrupt-names = "short";
+ interrupts = <0x3 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
+ <0x3 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "ovp", "short";
qcom,cabc;
qcom,external-pfet;
status = "disabled";

--
2.41.0


2023-06-26 20:08:43

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 4/7] arm64: dts: qcom: pm660l: Add missing short interrupt

Add the missing short interrupt. This fixes the schema warning:

wled@d800: interrupt-names: ['ovp'] is too short

Fixes: 7b56a804e58b ("arm64: dts: qcom: pm660l: Add WLED support")
Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/pm660l.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/pm660l.dtsi b/arch/arm64/boot/dts/qcom/pm660l.dtsi
index 87b71b7205b8..6fdbf507c262 100644
--- a/arch/arm64/boot/dts/qcom/pm660l.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm660l.dtsi
@@ -74,8 +74,9 @@ pm660l_lpg: pwm {
pm660l_wled: leds@d800 {
compatible = "qcom,pm660l-wled";
reg = <0xd800>, <0xd900>;
- interrupts = <0x3 0xd8 0x1 IRQ_TYPE_EDGE_RISING>;
- interrupt-names = "ovp";
+ interrupts = <0x3 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
+ <0x3 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "ovp", "short";
label = "backlight";

status = "disabled";

--
2.41.0


2023-06-26 20:09:01

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 5/7] arm64: dts: qcom: pmi8950: Add missing OVP interrupt

Add the missing OVP interrupt. This fixes the schema warning:

wled@d800: interrupt-names: ['short'] is too short

Fixes: 0d97fdf380b4 ("arm64: dts: qcom: Add configuration for PMI8950 peripheral")
Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/pmi8950.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
index c09a9681bc0c..1029f3b1bb9a 100644
--- a/arch/arm64/boot/dts/qcom/pmi8950.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
@@ -87,8 +87,9 @@ pmic@3 {
pmi8950_wled: leds@d800 {
compatible = "qcom,pmi8950-wled";
reg = <0xd800>, <0xd900>;
- interrupts = <0x3 0xd8 0x02 IRQ_TYPE_EDGE_RISING>;
- interrupt-names = "short";
+ interrupts = <0x3 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
+ <0x3 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "ovp", "short";
label = "backlight";

status = "disabled";

--
2.41.0


2023-06-26 20:09:33

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 7/7] arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3

Add the missing property to fix the dt checker warning:

qcom/sc8180x-primus.dtb: l3-cache: 'cache-unified' is a required property

Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform")
Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index 204deefbfa8b..5d8303a8dc95 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -64,6 +64,7 @@ L2_0: l2-cache {
L3_0: l3-cache {
compatible = "cache";
cache-level = <3>;
+ cache-unified;
};
};
};

--
2.41.0


2023-06-26 20:09:34

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 1/7] dt-bindings: qcom: Allow SoC names ending in "pro"

There are a couple of SoCs whose names end in "pro", with the currently-
upstream examples being msm8974pro and msm8996pro. Allow such suffix in
SoC-specific compatibles.

Fixes: 5aa332c5e7ca ("dt-bindings: qcom: document preferred compatible naming")
Signed-off-by: Konrad Dybcio <[email protected]>
---
Documentation/devicetree/bindings/arm/qcom-soc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
index e333ec4a9c5f..607a1cf1ef94 100644
--- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
@@ -31,7 +31,7 @@ properties:
compatible:
oneOf:
# Preferred naming style for compatibles of SoC components:
- - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+-.*$"
+ - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+(pro|)-.*$"
- pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"

# Legacy namings - variations of existing patterns/compatibles are OK,

--
2.41.0


2023-06-26 21:51:06

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/7] dt-bindings: qcom: Allow SoC names ending in "pro"

On Mon, Jun 26, 2023 at 10:00:23PM +0200, Konrad Dybcio wrote:
> There are a couple of SoCs whose names end in "pro", with the currently-
> upstream examples being msm8974pro and msm8996pro. Allow such suffix in
> SoC-specific compatibles.
>
> Fixes: 5aa332c5e7ca ("dt-bindings: qcom: document preferred compatible naming")
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/qcom-soc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> index e333ec4a9c5f..607a1cf1ef94 100644
> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> @@ -31,7 +31,7 @@ properties:
> compatible:
> oneOf:
> # Preferred naming style for compatibles of SoC components:
> - - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+-.*$"
> + - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+(pro|)-.*$"

"(pro)?" would be slightly better than "(pro|)" IMO.

Acked-by: Rob Herring <[email protected]>

> - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
>
> # Legacy namings - variations of existing patterns/compatibles are OK,
>
> --
> 2.41.0
>

2023-06-27 06:28:29

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 7/7] arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3

On 26/06/2023 22:00, Konrad Dybcio wrote:
> Add the missing property to fix the dt checker warning:
>
> qcom/sc8180x-primus.dtb: l3-cache: 'cache-unified' is a required property
>
> Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform")
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---

The last one, I hope...

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2023-07-14 06:00:48

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 0/7] random msm bindings fixes


On Mon, 26 Jun 2023 22:00:22 +0200, Konrad Dybcio wrote:
>


Applied, thanks!

[3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt
commit: 7e1f024ef0d1da456f61d00f01dc3287ede915b3
[4/7] arm64: dts: qcom: pm660l: Add missing short interrupt
commit: 9a4ac09db3c7413e334b4abd6b2f6de8930dd781
[5/7] arm64: dts: qcom: pmi8950: Add missing OVP interrupt
commit: 4d77b639531fd85b84a7079c3369908dfaddf8b2
[6/7] arm64: dts: qcom: pmi8994: Add missing OVP interrupt
commit: 8db94432690371b1736e9a2566a9b3d8a73d5a97
[7/7] arm64: dts: qcom: sc8180x: Add missing 'cache-unified' to L3
commit: e4322bb818bbcd36b441de9880fa4ac911a5eb51

Best regards,
--
Bjorn Andersson <[email protected]>

2023-07-19 04:20:39

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 0/7] random msm bindings fixes


On Mon, 26 Jun 2023 22:00:22 +0200, Konrad Dybcio wrote:
>


Applied, thanks!

[2/7] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Fix 8996 clocks
commit: 7784311cad42e67a1a51a9d1b961752c0f9b7200

Best regards,
--
Bjorn Andersson <[email protected]>

2023-07-22 05:24:19

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 0/7] random msm bindings fixes


On Mon, 26 Jun 2023 22:00:22 +0200, Konrad Dybcio wrote:
>


Applied, thanks!

[1/7] dt-bindings: qcom: Allow SoC names ending in "pro"
commit: e40266d90545ef11f95832177faedf41eadcc453

Best regards,
--
Bjorn Andersson <[email protected]>