2023-06-26 04:06:33

by Yunfei Dong (董云飞)

Subject: [PATCH v4,09/11] media: mediatek: vcodec: fix unreasonable parameter definition and style

Fix unreasonable coding style.
Fix unreasonable parameter definition.

Signed-off-by: Yunfei Dong <[email protected]>
---
.../media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h | 4 ++--
.../media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
index a18ba8f32d41..1a0375dd5b6d 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
@@ -19,7 +19,7 @@
#define IS_VDEC_INNER_RACING(capability) ((capability) & MTK_VCODEC_INNER_RACING)

/*
- * struct mtk_vdec_format_types - Structure used to get supported
+ * enum mtk_vdec_format_types - Structure used to get supported
* format types according to decoder capability
*/
enum mtk_vdec_format_types {
@@ -258,7 +258,7 @@ struct mtk_vcodec_dec_dev {
const struct mtk_vcodec_dec_pdata *vdec_pdata;

struct mtk_vcodec_fw *fw_handler;
- unsigned long id_counter;
+ u64 id_counter;

/* decoder hardware mutex lock */
struct mutex dec_mutex[MTK_VDEC_HW_MAX];
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h
index a88ef9078848..4804d8531a4e 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h
@@ -32,13 +32,13 @@
*/
struct mtk_vcodec_enc_pdata {
bool uses_ext;
- unsigned long min_bitrate;
- unsigned long max_bitrate;
+ u64 min_bitrate;
+ u64 max_bitrate;
const struct mtk_video_fmt *capture_formats;
size_t num_capture_formats;
const struct mtk_video_fmt *output_formats;
size_t num_output_formats;
- int core_id;
+ u8 core_id;
bool uses_34bit;
};

@@ -208,7 +208,7 @@ struct mtk_vcodec_enc_dev {
const struct mtk_vcodec_enc_pdata *venc_pdata;

struct mtk_vcodec_fw *fw_handler;
- unsigned long id_counter;
+ u64 id_counter;

/* encoder hardware mutex lock */
struct mutex enc_mutex;
--
2.18.0

2023-07-03 20:30:11

by Nicolas Dufresne

Subject: Re: [PATCH v4,09/11] media: mediatek: vcodec: fix unreasonable parameter definition and style

Le lundi 26 juin 2023 à 11:53 +0800, Yunfei Dong a écrit :
> Fix unreasonable coding style.
> Fix unreasonable parameter definition.
>
> Signed-off-by: Yunfei Dong <[email protected]>

Reviewed-by: Nicolas Dufresne <[email protected]>

> ---
> .../media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h | 4 ++--
> .../media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h | 8 ++++----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
> index a18ba8f32d41..1a0375dd5b6d 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
> @@ -19,7 +19,7 @@
> #define IS_VDEC_INNER_RACING(capability) ((capability) & MTK_VCODEC_INNER_RACING)
>
> /*
> - * struct mtk_vdec_format_types - Structure used to get supported
> + * enum mtk_vdec_format_types - Structure used to get supported
> * format types according to decoder capability
> */
> enum mtk_vdec_format_types {
> @@ -258,7 +258,7 @@ struct mtk_vcodec_dec_dev {
> const struct mtk_vcodec_dec_pdata *vdec_pdata;
>
> struct mtk_vcodec_fw *fw_handler;
> - unsigned long id_counter;
> + u64 id_counter;
>
> /* decoder hardware mutex lock */
> struct mutex dec_mutex[MTK_VDEC_HW_MAX];
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h
> index a88ef9078848..4804d8531a4e 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h
> @@ -32,13 +32,13 @@
> */
> struct mtk_vcodec_enc_pdata {
> bool uses_ext;
> - unsigned long min_bitrate;
> - unsigned long max_bitrate;
> + u64 min_bitrate;
> + u64 max_bitrate;
> const struct mtk_video_fmt *capture_formats;
> size_t num_capture_formats;
> const struct mtk_video_fmt *output_formats;
> size_t num_output_formats;
> - int core_id;
> + u8 core_id;
> bool uses_34bit;
> };
>
> @@ -208,7 +208,7 @@ struct mtk_vcodec_enc_dev {
> const struct mtk_vcodec_enc_pdata *venc_pdata;
>
> struct mtk_vcodec_fw *fw_handler;
> - unsigned long id_counter;
> + u64 id_counter;
>
> /* encoder hardware mutex lock */
> struct mutex enc_mutex;