2023-03-23 09:26:30

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] PCI: rcar-gen2: Use devm_platform_get_and_ioremap_resource()

According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li <[email protected]>
---
drivers/pci/controller/pci-rcar-gen2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
index 839695791757..d29866485361 100644
--- a/drivers/pci/controller/pci-rcar-gen2.c
+++ b/drivers/pci/controller/pci-rcar-gen2.c
@@ -290,8 +290,7 @@ static int rcar_pci_probe(struct platform_device *pdev)
priv = pci_host_bridge_priv(bridge);
bridge->sysdata = priv;

- cfg_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- reg = devm_ioremap_resource(dev, cfg_res);
+ reg = devm_platform_get_and_ioremap_resource(pdev, 0, &cfg_res);
if (IS_ERR(reg))
return PTR_ERR(reg);

--
2.20.1.7.g153144c


2023-04-20 14:35:23

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH -next] PCI: rcar-gen2: Use devm_platform_get_and_ioremap_resource()

On Thu, Mar 23, 2023 at 10:24 AM Yang Li <[email protected]> wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2023-06-26 11:22:25

by Krzysztof Wilczyński

[permalink] [raw]
Subject: Re: [PATCH -next] PCI: rcar-gen2: Use devm_platform_get_and_ioremap_resource()

Hello,

> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.

I took each separate patch:

https://lore.kernel.org/linux-pci/[email protected]
https://lore.kernel.org/linux-pci/[email protected]
https://lore.kernel.org/linux-pci/[email protected]
https://lore.kernel.org/linux-pci/[email protected]

Turned into a series and applied against a single branch.

Applied to controller/resources, thank you!

[01/04] PCI: rcar-gen2: Use devm_platform_get_and_ioremap_resource()
https://git.kernel.org/pci/pci/c/8b88299ef429
[02/04] PCI: v3: Use devm_platform_get_and_ioremap_resource()
https://git.kernel.org/pci/pci/c/cc456373aa57
[03/04] PCI: xgene-msi: Use devm_platform_get_and_ioremap_resource()
https://git.kernel.org/pci/pci/c/7a081062046f
[04/04] PCI: imx6: Use devm_platform_get_and_ioremap_resource()
https://git.kernel.org/pci/pci/c/860955d0db7d

Krzysztof