The bootargs node is also added by the EFI stub in the function
update_fdt(), so add it to the table.
Signed-off-by: Alexandre Ghiti <[email protected]>
Reviewed-by: Atish Patra <[email protected]>
Reviewed-by: Song Shuai <[email protected]>
---
Documentation/arm/uefi.rst | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/arm/uefi.rst b/Documentation/arm/uefi.rst
index baebe688a006..2b7ad9bd7cd2 100644
--- a/Documentation/arm/uefi.rst
+++ b/Documentation/arm/uefi.rst
@@ -50,7 +50,7 @@ The stub populates the FDT /chosen node with (and the kernel scans for) the
following parameters:
========================== ====== ===========================================
-Name Size Description
+Name Type Description
========================== ====== ===========================================
linux,uefi-system-table 64-bit Physical address of the UEFI System Table.
@@ -67,4 +67,6 @@ linux,uefi-mmap-desc-ver 32-bit Version of the mmap descriptor format.
kaslr-seed 64-bit Entropy used to randomize the kernel image
base address location.
+
+bootargs String Kernel command line
========================== ====== ===========================================
--
2.39.2
The EFI stub is supported on RISC-V so update the documentation that
explains how the boot image header was reused to support it.
Signed-off-by: Alexandre Ghiti <[email protected]>
Reviewed-by: Atish Patra <[email protected]>
Reviewed-by: Palmer Dabbelt <[email protected]>
Acked-by: Palmer Dabbelt <[email protected]>
---
Documentation/riscv/boot-image-header.rst | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/riscv/boot-image-header.rst b/Documentation/riscv/boot-image-header.rst
index a4a45310c4c4..df2ffc173e80 100644
--- a/Documentation/riscv/boot-image-header.rst
+++ b/Documentation/riscv/boot-image-header.rst
@@ -28,11 +28,11 @@ header in future.
Notes
=====
-- This header can also be reused to support EFI stub for RISC-V in future. EFI
- specification needs PE/COFF image header in the beginning of the kernel image
- in order to load it as an EFI application. In order to support EFI stub,
- code0 should be replaced with "MZ" magic string and res3(at offset 0x3c) should
- point to the rest of the PE/COFF header.
+- This header is also reused to support EFI stub for RISC-V. EFI specification
+ needs PE/COFF image header in the beginning of the kernel image in order to
+ load it as an EFI application. In order to support EFI stub, code0 is replaced
+ with "MZ" magic string and res3(at offset 0x3c) points to the rest of the
+ PE/COFF header.
- version field indicate header version number
--
2.39.2
On Mon, 26 Jun 2023 07:36:24 PDT (-0700), [email protected] wrote:
> The bootargs node is also added by the EFI stub in the function
> update_fdt(), so add it to the table.
>
> Signed-off-by: Alexandre Ghiti <[email protected]>
> Reviewed-by: Atish Patra <[email protected]>
> Reviewed-by: Song Shuai <[email protected]>
> ---
> Documentation/arm/uefi.rst | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/arm/uefi.rst b/Documentation/arm/uefi.rst
> index baebe688a006..2b7ad9bd7cd2 100644
> --- a/Documentation/arm/uefi.rst
> +++ b/Documentation/arm/uefi.rst
> @@ -50,7 +50,7 @@ The stub populates the FDT /chosen node with (and the kernel scans for) the
> following parameters:
>
> ========================== ====== ===========================================
> -Name Size Description
> +Name Type Description
> ========================== ====== ===========================================
> linux,uefi-system-table 64-bit Physical address of the UEFI System Table.
>
> @@ -67,4 +67,6 @@ linux,uefi-mmap-desc-ver 32-bit Version of the mmap descriptor format.
>
> kaslr-seed 64-bit Entropy used to randomize the kernel image
> base address location.
> +
> +bootargs String Kernel command line
> ========================== ====== ===========================================
I remember having said this somewhere, but it's not on lore for this
version. This touches Arm stuff, so I'd prefer an Ack from someone
before touching it.
Also: it looks like this missed e790a4ce5290 ("arm: docs: Move Arm
documentation to Documentation/arch/").
On Mon, 26 Jun 2023 07:36:26 PDT (-0700), [email protected] wrote:
> The EFI stub is supported on RISC-V so update the documentation that
> explains how the boot image header was reused to support it.
>
> Signed-off-by: Alexandre Ghiti <[email protected]>
> Reviewed-by: Atish Patra <[email protected]>
> Reviewed-by: Palmer Dabbelt <[email protected]>
> Acked-by: Palmer Dabbelt <[email protected]>
> ---
> Documentation/riscv/boot-image-header.rst | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/riscv/boot-image-header.rst b/Documentation/riscv/boot-image-header.rst
> index a4a45310c4c4..df2ffc173e80 100644
> --- a/Documentation/riscv/boot-image-header.rst
> +++ b/Documentation/riscv/boot-image-header.rst
> @@ -28,11 +28,11 @@ header in future.
> Notes
> =====
>
> -- This header can also be reused to support EFI stub for RISC-V in future. EFI
> - specification needs PE/COFF image header in the beginning of the kernel image
> - in order to load it as an EFI application. In order to support EFI stub,
> - code0 should be replaced with "MZ" magic string and res3(at offset 0x3c) should
> - point to the rest of the PE/COFF header.
> +- This header is also reused to support EFI stub for RISC-V. EFI specification
> + needs PE/COFF image header in the beginning of the kernel image in order to
> + load it as an EFI application. In order to support EFI stub, code0 is replaced
> + with "MZ" magic string and res3(at offset 0x3c) points to the rest of the
> + PE/COFF header.
>
> - version field indicate header version number
Acked-by: Palmer Dabbelt <[email protected]>
Alexandre Ghiti <[email protected]> writes:
> The bootargs node is also added by the EFI stub in the function
> update_fdt(), so add it to the table.
>
> Signed-off-by: Alexandre Ghiti <[email protected]>
> Reviewed-by: Atish Patra <[email protected]>
> Reviewed-by: Song Shuai <[email protected]>
> ---
> Documentation/arm/uefi.rst | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
So I'm not sure if I'm supposed to be applying these patches, or whether
they will go through the arch trees?
In the former case, they don't apply to docs-next, so could I get a
respin please?
Thanks,
jon
On 21/07/2023 23:07, Jonathan Corbet wrote:
> Alexandre Ghiti <[email protected]> writes:
>
>> The bootargs node is also added by the EFI stub in the function
>> update_fdt(), so add it to the table.
>>
>> Signed-off-by: Alexandre Ghiti <[email protected]>
>> Reviewed-by: Atish Patra <[email protected]>
>> Reviewed-by: Song Shuai <[email protected]>
>> ---
>> Documentation/arm/uefi.rst | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
> So I'm not sure if I'm supposed to be applying these patches, or whether
> they will go through the arch trees?
>
> In the former case, they don't apply to docs-next, so could I get a
> respin please?
Yes sure, I'll do that now. BTW all the arch documentation was moved in
Documentation/arch/, but not the riscv, are you working on this or
should we?
Thanks,
Alex
>
> Thanks,
>
> jon
>
> _______________________________________________
> linux-riscv mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Alexandre Ghiti <[email protected]> writes:
>> In the former case, they don't apply to docs-next, so could I get a
>> respin please?
>
> Yes sure, I'll do that now. BTW all the arch documentation was moved in
> Documentation/arch/, but not the riscv, are you working on this or
> should we?
I'll get there - unless somebody beats me to it :)
Thanks,
jon