Don't populate the read-only array on the stack, instead make it
static const.
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/power/supply/bd99954-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/bd99954-charger.c b/drivers/power/supply/bd99954-charger.c
index 086dcf4033c1..1ed1d9f99fb3 100644
--- a/drivers/power/supply/bd99954-charger.c
+++ b/drivers/power/supply/bd99954-charger.c
@@ -536,7 +536,7 @@ static irqreturn_t bd9995x_irq_handler_thread(int irq, void *private)
for_each_set_bit(i, &tmp, 7) {
int sub_status, sub_mask;
- int sub_status_reg[] = {
+ static const int sub_status_reg[] = {
INT1_STATUS, INT2_STATUS, INT3_STATUS, INT4_STATUS,
INT5_STATUS, INT6_STATUS, INT7_STATUS,
};
--
2.39.2
On 6/27/23 15:17, Colin Ian King wrote:
> Don't populate the read-only array on the stack, instead make it
> static const.
>
> Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Matti Vaittinen <[email protected]>
Thanks!
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
Hi,
On Tue, Jun 27, 2023 at 03:38:35PM +0300, Matti Vaittinen wrote:
> On 6/27/23 15:17, Colin Ian King wrote:
> > Don't populate the read-only array on the stack, instead make it
> > static const.
> >
> > Signed-off-by: Colin Ian King <[email protected]>
>
> Reviewed-by: Matti Vaittinen <[email protected]>
Thanks, queued.
-- Sebastian