2023-06-07 21:27:19

by Dmitry Rokosov

Subject: [PATCH v1 3/6] arm64: dts: meson: a1: enable efuse controller and setup its clk

From: Alexey Romanov <[email protected]>

EFUSE A1 controller uses CLKID_OTP clock and PWRC_OTP_ID power domain.

Signed-off-by: Alexey Romanov <[email protected]>
Signed-off-by: Dmitry Rokosov <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
index b2563c7d3842..63faccfc1134 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
@@ -44,6 +44,16 @@ l2: l2-cache0 {
};
};

+ efuse: efuse {
+ compatible = "amlogic,meson-gxbb-efuse";
+ clocks = <&clkc_periphs CLKID_OTP>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ secure-monitor = <&sm>;
+ power-domains = <&pwrc PWRC_OTP_ID>;
+ status = "okay";
+ };
+
psci {
compatible = "arm,psci-1.0";
method = "smc";
--
2.36.0

2023-06-25 21:07:36

by Martin Blumenstingl

Subject: Re: [PATCH v1 3/6] arm64: dts: meson: a1: enable efuse controller and setup its clk

On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <[email protected]> wrote:
[...]
> + efuse: efuse {
> + compatible = "amlogic,meson-gxbb-efuse";
> + clocks = <&clkc_periphs CLKID_OTP>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + secure-monitor = <&sm>;
> + power-domains = <&pwrc PWRC_OTP_ID>;
> + status = "okay";
If eFuse is always enabled then we can just drop status = "okay" as
that's the default.

2023-06-28 14:52:23

by Dmitry Rokosov

Subject: Re: [PATCH v1 3/6] arm64: dts: meson: a1: enable efuse controller and setup its clk

On Sun, Jun 25, 2023 at 10:50:37PM +0200, Martin Blumenstingl wrote:
> On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <[email protected]> wrote:
> [...]
> > + efuse: efuse {
> > + compatible = "amlogic,meson-gxbb-efuse";
> > + clocks = <&clkc_periphs CLKID_OTP>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + secure-monitor = <&sm>;
> > + power-domains = <&pwrc PWRC_OTP_ID>;
> > + status = "okay";
> If eFuse is always enabled then we can just drop status = "okay" as
> that's the default.

Ahh, okay. I wasn't aware of that behavior. Thank you for pointing it
out!

--
Thank you,
Dmitry