2023-06-07 20:19:35

by Dmitry Rokosov

Subject: [PATCH v1 4/6] arm64: dts: meson: a1: introduce SPI Flash Controller

From: Martin Kurbanov <[email protected]>

This controller can be used for spinand flash connection.

Signed-off-by: Martin Kurbanov <[email protected]>
Signed-off-by: Dmitry Rokosov <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
index 63faccfc1134..0efd922ca7e1 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
@@ -199,6 +199,16 @@ gic: interrupt-controller@ff901000 {
#address-cells = <0>;
};

+ spifc: spi@fd000400 {
+ compatible = "amlogic,a1-spifc";
+ reg = <0x0 0xfd000400 0x0 0x290>;
+ clocks = <&clkc_periphs CLKID_SPIFC>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ power-domains = <&pwrc PWRC_SPIFC_ID>;
+ status = "disabled";
+ };
+
usb: usb@fe004400 {
status = "disabled";
compatible = "amlogic,meson-a1-usb-ctrl";
--
2.36.0

2023-06-25 21:25:39

by Martin Blumenstingl

Subject: Re: [PATCH v1 4/6] arm64: dts: meson: a1: introduce SPI Flash Controller

On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <[email protected]> wrote:
>
> From: Martin Kurbanov <[email protected]>
>
> This controller can be used for spinand flash connection.
>
> Signed-off-by: Martin Kurbanov <[email protected]>
> Signed-off-by: Dmitry Rokosov <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> index 63faccfc1134..0efd922ca7e1 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> @@ -199,6 +199,16 @@ gic: interrupt-controller@ff901000 {
> #address-cells = <0>;
> };
>
> + spifc: spi@fd000400 {
please also sort this numerically, so it should appear before &apb

2023-06-28 14:53:31

by Dmitry Rokosov

Subject: Re: [PATCH v1 4/6] arm64: dts: meson: a1: introduce SPI Flash Controller

On Sun, Jun 25, 2023 at 11:03:21PM +0200, Martin Blumenstingl wrote:
> On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <[email protected]> wrote:
> >
> > From: Martin Kurbanov <[email protected]>
> >
> > This controller can be used for spinand flash connection.
> >
> > Signed-off-by: Martin Kurbanov <[email protected]>
> > Signed-off-by: Dmitry Rokosov <[email protected]>
> > ---
> > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > index 63faccfc1134..0efd922ca7e1 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> > @@ -199,6 +199,16 @@ gic: interrupt-controller@ff901000 {
> > #address-cells = <0>;
> > };
> >
> > + spifc: spi@fd000400 {
> please also sort this numerically, so it should appear before &apb

Sure, not a problem. If things have base addresses, all of them ought to
be sorted numerically.

--
Thank you,
Dmitry