2023-06-29 04:00:27

by Luo Jie

Subject: [PATCH 2/3] net: phy: at803x: remove 1000BaseX mode of qca8081

QCA808x does not support the link mode 1000BaseX.

Signed-off-by: Luo Jie <[email protected]>
---
drivers/net/phy/at803x.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 3339ca372b24..29aab7eaaa90 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -920,7 +920,7 @@ static int at803x_get_features(struct phy_device *phydev)
}
}

- if (phydev->drv->phy_id != ATH8031_PHY_ID)
+ if (phydev->drv->phy_id != ATH8031_PHY_ID && phydev->drv->phy_id != QCA8081_PHY_ID)
return 0;

/* AR8031/AR8033 have different status registers
@@ -933,6 +933,8 @@ static int at803x_get_features(struct phy_device *phydev)
*
* Remove this mode from the supported link modes
* when not operating in 1000BaseX mode.
+ *
+ * QCA808x does not support 1000BaseX mode.
*/
if (!priv->is_1000basex)
linkmode_clear_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT,
--
2.17.1

2023-06-29 13:39:51

by Andrew Lunn

Subject: Re: [PATCH 2/3] net: phy: at803x: remove 1000BaseX mode of qca8081

On Thu, Jun 29, 2023 at 11:48:45AM +0800, Luo Jie wrote:
> QCA808x does not support the link mode 1000BaseX.
>
> Signed-off-by: Luo Jie <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew