2023-06-29 12:39:49

by Huang Rui

Subject: [PATCHv2] ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook G10

In the commit 3e10f6ca76c4 ("ALSA: hda/realtek: Add quirk for
HP EliteBook G10 laptops"), speakers are fixed but mute/micmute
LEDs does not lit. Need the ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED
to get all mute/micmute LEDs working.

Signed-off-by: Huang Rui <[email protected]>
Fixes: 3e10f6ca76c4 ("ALSA: hda/realtek: Add quirk for HP EliteBook G10 laptops")
---
V1 -> V2: Add fixes to link a previously committed issue
---
sound/pci/hda/patch_realtek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index dabfdecece26..425c87733e79 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9491,7 +9491,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8b65, "HP ProBook 455 15.6 inch G10 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b66, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b70, "HP EliteBook 835 G10", ALC287_FIXUP_CS35L41_I2C_2),
- SND_PCI_QUIRK(0x103c, 0x8b72, "HP EliteBook 845 G10", ALC287_FIXUP_CS35L41_I2C_2),
+ SND_PCI_QUIRK(0x103c, 0x8b72, "HP EliteBook 845 G10", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b74, "HP EliteBook 845W G10", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x103c, 0x8b77, "HP ElieBook 865 G10", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x103c, 0x8b7a, "HP", ALC236_FIXUP_HP_GPIO_LED),
--
2.41.0

2023-06-29 13:02:43

by Takashi Iwai

Subject: Re: [PATCHv2] ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook G10

On Thu, 29 Jun 2023 14:35:57 +0200,
Huang Rui wrote:
>
> In the commit 3e10f6ca76c4 ("ALSA: hda/realtek: Add quirk for
> HP EliteBook G10 laptops"), speakers are fixed but mute/micmute
> LEDs does not lit. Need the ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED
> to get all mute/micmute LEDs working.
>
> Signed-off-by: Huang Rui <[email protected]>
> Fixes: 3e10f6ca76c4 ("ALSA: hda/realtek: Add quirk for HP EliteBook G10 laptops")
> ---
> V1 -> V2: Add fixes to link a previously committed issue

This was already fixed by Andi's patch.


thanks,

Takashi