2023-06-21 13:19:14

by Colin Ian King

Subject: [PATCH][next] btrfs: scrub: remove redundant division of stripe_nr

Variable stripe_nr is being divided by map->num_stripes however the
result is never read. The division and assignment are redundant and
can be removed. Cleans up clang scan build warning:

fs/btrfs/scrub.c:1264:3: warning: Value stored to 'stripe_nr' is
never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
fs/btrfs/scrub.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
index 2c7fdbb60314..8fc4f9ea3d20 100644
--- a/fs/btrfs/scrub.c
+++ b/fs/btrfs/scrub.c
@@ -1261,7 +1261,6 @@ static int get_raid56_logic_offset(u64 physical, int num,

/* Work out the disk rotation on this stripe-set */
rot = stripe_nr % map->num_stripes;
- stripe_nr /= map->num_stripes;
/* calculate which stripe this data locates */
rot += i;
stripe_index = rot % map->num_stripes;
--
2.39.2

2023-06-29 15:58:09

by David Sterba

Subject: Re: [PATCH][next] btrfs: scrub: remove redundant division of stripe_nr

On Wed, Jun 21, 2023 at 02:09:37PM +0100, Colin Ian King wrote:
> Variable stripe_nr is being divided by map->num_stripes however the
> result is never read. The division and assignment are redundant and
> can be removed. Cleans up clang scan build warning:
>
> fs/btrfs/scrub.c:1264:3: warning: Value stored to 'stripe_nr' is
> never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>

Added to misc-next, thanks.