2023-06-30 12:09:58

by Gowthami Thiagarajan

[permalink] [raw]
Subject: [PATCH 2/6] dt-bindings: perf: marvell: Add YAML schemas for Marvell PEM pmu

Add device tree bindings for Marvell PEM performance monitor unit

Signed-off-by: Gowthami Thiagarajan <[email protected]>
Signed-off-by: Linu Cherian <[email protected]>
---
.../bindings/perf/marvell-odyssey-pem.yaml | 38 +++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 Documentation/devicetree/bindings/perf/marvell-odyssey-pem.yaml

diff --git a/Documentation/devicetree/bindings/perf/marvell-odyssey-pem.yaml b/Documentation/devicetree/bindings/perf/marvell-odyssey-pem.yaml
new file mode 100644
index 000000000000..6af201fbccd8
--- /dev/null
+++ b/Documentation/devicetree/bindings/perf/marvell-odyssey-pem.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/perf/marvell-odyssey-pem.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Odyssey PCIe interface performance monitor
+
+maintainers:
+ - Linu Cherian <[email protected]>
+ - Gowthami Thiagarajan <[email protected]>
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - marvell,pem-pmu
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ bus {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ pmu@8e0000005000 {
+ compatible = "marvell,pem-pmu";
+ reg = <0x8E00 0x00005000 0x0 0x3000>;
+ };
+ };
--
2.25.1



2023-07-02 09:52:36

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/6] dt-bindings: perf: marvell: Add YAML schemas for Marvell PEM pmu

On 30/06/2023 14:03, Gowthami Thiagarajan wrote:
> Add device tree bindings for Marvell PEM performance monitor unit
>
> Signed-off-by: Gowthami Thiagarajan <[email protected]>
> Signed-off-by: Linu Cherian <[email protected]>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested by our
tools. Performing review on untested code might be a waste of time, thus
I will skip this patch entirely till you follow the process allowing the
patch to be tested.

Please kindly resend and include all necessary To/Cc entries.


Best regards,
Krzysztof


2023-07-28 16:05:40

by Mark Rutland

[permalink] [raw]
Subject: Re: [PATCH 2/6] dt-bindings: perf: marvell: Add YAML schemas for Marvell PEM pmu

On Fri, Jun 30, 2023 at 05:33:47PM +0530, Gowthami Thiagarajan wrote:
> Add device tree bindings for Marvell PEM performance monitor unit
>
> Signed-off-by: Gowthami Thiagarajan <[email protected]>
> Signed-off-by: Linu Cherian <[email protected]>

As Krzysztof mentioned, the device tree list (and the DT bindings maintainers)
haven't been Cc'd, so this cannot be acked.

When resending, please CC the devicetree list, Rob, and Conor:

[mark@lakrids:~/src/linux]% ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/perf
Will Deacon <[email protected]> (maintainer:ARM PMU PROFILING AND DEBUGGING)
Mark Rutland <[email protected]> (maintainer:ARM PMU PROFILING AND DEBUGGING)
Rob Herring <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Conor Dooley <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
[email protected] (moderated list:ARM PMU PROFILING AND DEBUGGING)
[email protected] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
[email protected] (open list)

Thanks,
Mark.

> ---
> .../bindings/perf/marvell-odyssey-pem.yaml | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/perf/marvell-odyssey-pem.yaml
>
> diff --git a/Documentation/devicetree/bindings/perf/marvell-odyssey-pem.yaml b/Documentation/devicetree/bindings/perf/marvell-odyssey-pem.yaml
> new file mode 100644
> index 000000000000..6af201fbccd8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/perf/marvell-odyssey-pem.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/perf/marvell-odyssey-pem.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Odyssey PCIe interface performance monitor
> +
> +maintainers:
> + - Linu Cherian <[email protected]>
> + - Gowthami Thiagarajan <[email protected]>
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - marvell,pem-pmu
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + bus {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + pmu@8e0000005000 {
> + compatible = "marvell,pem-pmu";
> + reg = <0x8E00 0x00005000 0x0 0x3000>;
> + };
> + };
> --
> 2.25.1
>
>