Add device tree bindings for Marvell Odyssey LLC-TAD performance
monitor unit
Signed-off-by: Gowthami Thiagarajan <[email protected]>
---
.../bindings/perf/marvell-odyssey-tad.yaml | 63 +++++++++++++++++++
1 file changed, 63 insertions(+)
create mode 100644 Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml
diff --git a/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml b/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml
new file mode 100644
index 000000000000..139567166f77
--- /dev/null
+++ b/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml
@@ -0,0 +1,63 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/perf/marvell-odyssey-tad.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Odyssey LLC-TAD performance monitor
+
+maintainers:
+ - Gowthami Thiagarajan <[email protected]>
+
+description: |
+ The Tag-and-Data units (TADs) maintain coherence and contain CN10K
+ shared on-chip last level cache (LLC). The tad pmu measures the
+ performance of last-level cache. Each tad pmu supports up to eight
+ counters.
+
+ The DT setup comprises of number of tad blocks, the sizes of pmu
+ regions, tad blocks and overall base address of the HW.
+
+properties:
+ compatible:
+ const: marvell,odyssey-tad-pmu
+
+ reg:
+ maxItems: 1
+
+ marvell,tad-cnt:
+ description: specifies the number of tads on the soc
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ marvell,tad-page-size:
+ description: specifies the size of each tad page
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ marvell,tad-pmu-page-size:
+ description: specifies the size of page that the pmu uses
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+required:
+ - compatible
+ - reg
+ - marvell,tad-cnt
+ - marvell,tad-page-size
+ - marvell,tad-pmu-page-size
+
+additionalProperties: false
+
+examples:
+ - |
+
+ tad {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ tad_pmu@80000000 {
+ compatible = "marvell,odyssey-tad-pmu";
+ reg = <0x87E2 0x2B030000 0x0 0x1000>;
+ marvell,tad-cnt = <1>;
+ marvell,tad-page-size = <0x1000>;
+ marvell,tad-pmu-page-size = <0x1000>;
+ };
+ };
--
2.25.1
On 30/06/2023 14:03, Gowthami Thiagarajan wrote:
> Add device tree bindings for Marvell Odyssey LLC-TAD performance
> monitor unit
>
> Signed-off-by: Gowthami Thiagarajan <[email protected]>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
You missed at least DT list (maybe more), so this won't be tested by our
tools. Performing review on untested code might be a waste of time, thus
I will skip this patch entirely till you follow the process allowing the
patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
> ---
> .../bindings/perf/marvell-odyssey-tad.yaml | 63 +++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml
>
> diff --git a/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml b/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml
> new file mode 100644
> index 000000000000..139567166f77
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml
Filename does not match compatible.
> +examples:
> + - |
> +
> + tad {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + tad_pmu@80000000 {
Node names should be generic. See also explanation and list of examples
in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "marvell,odyssey-tad-pmu";
> + reg = <0x87E2 0x2B030000 0x0 0x1000>;
lowercase hex
Best regards,
Krzysztof
Hi,
> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Sunday, July 2, 2023 2:56 PM
> To: Gowthami Thiagarajan <[email protected]>; [email protected]; [email protected]; linux-arm-
> [email protected]; [email protected]
> Cc: Sunil Kovvuri Goutham <[email protected]>; Bharat Bhushan <[email protected]>; George
> Cherian <[email protected]>; Linu Cherian <[email protected]>
> Subject: [EXT] Re: [PATCH 4/6] dt-bindings: perf: marvell: Add YAML schemas for Marvell Odyssey LLC-
> TAD pmu
>
> External Email
>
> ----------------------------------------------------------------------
> On 30/06/2023 14:03, Gowthami Thiagarajan wrote:
> > Add device tree bindings for Marvell Odyssey LLC-TAD performance
> > monitor unit
> >
> > Signed-off-by: Gowthami Thiagarajan <[email protected]>
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> You missed at least DT list (maybe more), so this won't be tested by our
> tools. Performing review on untested code might be a waste of time, thus
> I will skip this patch entirely till you follow the process allowing the
> patch to be tested.
>
> Please kindly resend and include all necessary To/Cc entries.
Missed sending to DT list. Will add everyone while resending.
>
> > ---
> > .../bindings/perf/marvell-odyssey-tad.yaml | 63 +++++++++++++++++++
> > 1 file changed, 63 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml
> b/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml
> > new file mode 100644
> > index 000000000000..139567166f77
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml
>
> Filename does not match compatible.
Ack.
>
>
>
> > +examples:
> > + - |
> > +
> > + tad {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + tad_pmu@80000000 {
>
> Node names should be generic. See also explanation and list of examples
> in DT specification:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__devicetree-
> 2Dspecification.readthedocs.io_en_latest_chapter2-2Ddevicetree-2Dbasics.html-23generic-2Dnames-
> 2Drecommendation&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=jXyDe1pTHpmFH9abKZ66HpyuWJquipUlbI9yktcgBgU&m=GdU
> qi5f4jgPpB5WqFNmUoZBzc3eljzT7CbdkU7I2c2GJn6OrVE5DUNFL2qeL_k05&s=kjtFmv_ypTnmDrZqOm7nTET--
> ZCfPMWoyFBAQZVd7J8&e=
Ack.
>
> > + compatible = "marvell,odyssey-tad-pmu";
> > + reg = <0x87E2 0x2B030000 0x0 0x1000>;
>
> lowercase hex
Ack. Will make the changes in the next version.
-Thanks,
Gowthami
>
> Best regards,
> Krzysztof