2023-06-30 12:40:01

by Gowthami Thiagarajan

[permalink] [raw]
Subject: [PATCH 6/6] dt-bindings: Add YAML schemas for Marvell Odyssey DDR PMU

Add device tree bindings for Marvell Odyssey DDR PMU.

Signed-off-by: Gowthami Thiagarajan <[email protected]>
---
.../devicetree/bindings/perf/marvell-cn10k-ddr.yaml | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/perf/marvell-cn10k-ddr.yaml b/Documentation/devicetree/bindings/perf/marvell-cn10k-ddr.yaml
index a18dd0a8c43a..a435cbf4aea0 100644
--- a/Documentation/devicetree/bindings/perf/marvell-cn10k-ddr.yaml
+++ b/Documentation/devicetree/bindings/perf/marvell-cn10k-ddr.yaml
@@ -11,10 +11,15 @@ maintainers:

properties:
compatible:
- items:
+ oneOf:
- enum:
- marvell,cn10k-ddr-pmu
-
+ - marvell,odyssey-ddr-pmu
+ - items:
+ - enum:
+ - marvell,cn10k-ddr-pmu
+ - marvell,odyssey-ddr-pmu
+ - const: marvell,cn10k-ddr-pmu
reg:
maxItems: 1

--
2.25.1



2023-07-02 10:21:56

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 6/6] dt-bindings: Add YAML schemas for Marvell Odyssey DDR PMU

On 30/06/2023 14:03, Gowthami Thiagarajan wrote:
> Add device tree bindings for Marvell Odyssey DDR PMU.

For all patches:
1. A nit, subject: drop second/last, redundant "YAML schemas for". The
"dt-bindings" prefix is already stating that these are bindings.

2. Please use subject prefixes matching the subsystem. You can get them
for example with `git log --oneline -- DIRECTORY_OR_FILE` on the
directory your patch is touching.

3. Please use scripts/get_maintainers.pl to get a list of necessary
people and lists to CC. It might happen, that command when run on an
older kernel, gives you outdated entries. Therefore please be sure you
base your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested by our
tools. Performing review on untested code might be a waste of time, thus
I will skip this patch entirely till you follow the process allowing the
patch to be tested.

Please kindly resend and include all necessary To/Cc entries.


>

Best regards,
Krzysztof