2023-07-02 13:44:13

by Tom Rix

[permalink] [raw]
Subject: [PATCH] regulator: set variables clkin_name and xin_name storage-class-specifier to static

smatch reports
drivers/regulator/raa215300.c:41:12: warning: symbol
'clkin_name' was not declared. Should it be static?
drivers/regulator/raa215300.c:42:12: warning: symbol
'xin_name' was not declared. Should it be static?

These variables are only used in their defining file, so it should be static.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/regulator/raa215300.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/raa215300.c b/drivers/regulator/raa215300.c
index 24a1c89f5dbc..d21c6c207226 100644
--- a/drivers/regulator/raa215300.c
+++ b/drivers/regulator/raa215300.c
@@ -38,8 +38,8 @@
#define RAA215300_REG_BLOCK_EN_RTC_EN BIT(6)
#define RAA215300_RTC_DEFAULT_ADDR 0x6f

-const char *clkin_name = "clkin";
-const char *xin_name = "xin";
+static const char *clkin_name = "clkin";
+static const char *xin_name = "xin";
static struct clk *clk;

static const struct regmap_config raa215300_regmap_config = {
--
2.27.0