2023-07-03 02:52:48

by Yang Li

Subject: [PATCH -next] xfs: Remove unneeded semicolon

./fs/xfs/xfs_extfree_item.c:723:3-4: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5728
Signed-off-by: Yang Li <[email protected]>
---
fs/xfs/xfs_extfree_item.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_extfree_item.c b/fs/xfs/xfs_extfree_item.c
index cdd8ebb6e7cb..f1a5ecf099aa 100644
--- a/fs/xfs/xfs_extfree_item.c
+++ b/fs/xfs/xfs_extfree_item.c
@@ -720,7 +720,7 @@ xfs_efi_item_recover(
requeue_only = true;
continue;
}
- };
+ }

if (error == -EFSCORRUPTED)
XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp,
--
2.20.1.7.g153144c

2023-07-03 04:13:23

by Darrick J. Wong

Subject: Re: [PATCH -next] xfs: Remove unneeded semicolon

On Mon, Jul 03, 2023 at 09:21:31AM +0800, Yang Li wrote:
> ./fs/xfs/xfs_extfree_item.c:723:3-4: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5728
> Signed-off-by: Yang Li <[email protected]>
> ---
> fs/xfs/xfs_extfree_item.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_extfree_item.c b/fs/xfs/xfs_extfree_item.c
> index cdd8ebb6e7cb..f1a5ecf099aa 100644
> --- a/fs/xfs/xfs_extfree_item.c
> +++ b/fs/xfs/xfs_extfree_item.c
> @@ -720,7 +720,7 @@ xfs_efi_item_recover(
> requeue_only = true;
> continue;
> }
> - };
> + }

Looks ok,
Reviewed-by: Darrick J. Wong <[email protected]>

--D

>
> if (error == -EFSCORRUPTED)
> XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp,
> --
> 2.20.1.7.g153144c
>