2023-07-03 11:59:02

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] scsi: aacraid: avoid -Warray-bounds warning

From: Arnd Bergmann <[email protected]>

The one-element array in aac_aifcmd is actually meant as a flexible array,
and causes an overflow warning that can be avoided using the normal
flex arrays:

drivers/scsi/aacraid/commsup.c:1166:17: error: array index 1 is past the end of the array (that has type 'u8[1]' (aka 'unsigned char[1]'), cast to '__le32 *' (aka 'unsigned int *')) [-Werror,-Warray-bounds]
(((__le32 *)aifcmd->data)[1] == cpu_to_le32(3));
^ ~

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/scsi/aacraid/aacraid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
index 7c6efde75da66..73b6ac0c01f54 100644
--- a/drivers/scsi/aacraid/aacraid.h
+++ b/drivers/scsi/aacraid/aacraid.h
@@ -2618,7 +2618,7 @@ struct aac_hba_info {
struct aac_aifcmd {
__le32 command; /* Tell host what type of notify this is */
__le32 seqnum; /* To allow ordering of reports (if necessary) */
- u8 data[1]; /* Undefined length (from kernel viewpoint) */
+ u8 data[]; /* Undefined length (from kernel viewpoint) */
};

/**
--
2.39.2



2023-07-06 02:04:55

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: aacraid: avoid -Warray-bounds warning


Arnd,

> The one-element array in aac_aifcmd is actually meant as a flexible
> array, and causes an overflow warning that can be avoided using the
> normal flex arrays:

Applied to 6.5/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering