From: Michael Haener <[email protected]>
This patch series brings SERDES support for the mv88e632x family.
Michael Haener (3):
net: dsa: mv88e632x: Refactor serdes read
net: dsa: mv88e632x: Refactor serdes write
net: dsa: mv88e632x: Add SERDES ops
drivers/net/dsa/mv88e6xxx/chip.c | 35 ++++++++++++++
drivers/net/dsa/mv88e6xxx/chip.h | 5 ++
drivers/net/dsa/mv88e6xxx/serdes.c | 76 +++++++++++++++++++++++-------
drivers/net/dsa/mv88e6xxx/serdes.h | 33 +++++++++++++
4 files changed, 133 insertions(+), 16 deletions(-)
--
2.41.0
On Tue, 2023-07-04 at 08:59 +0200, M. Haener wrote:
> From: Michael Haener <[email protected]>
>
> This patch series brings SERDES support for the mv88e632x family.
Changelog:
v2: rebased onto Russell Kings series dsa/88e6xxx/phylink
>
> Michael Haener (3):
> net: dsa: mv88e632x: Refactor serdes read
> net: dsa: mv88e632x: Refactor serdes write
> net: dsa: mv88e632x: Add SERDES ops
>
> drivers/net/dsa/mv88e6xxx/chip.c | 35 ++++++++++++++
> drivers/net/dsa/mv88e6xxx/chip.h | 5 ++
> drivers/net/dsa/mv88e6xxx/serdes.c | 76 +++++++++++++++++++++++-----
> --
> drivers/net/dsa/mv88e6xxx/serdes.h | 33 +++++++++++++
> 4 files changed, 133 insertions(+), 16 deletions(-)
>
On Tue, Jul 04, 2023 at 07:17:55AM +0000, Haener, Michael wrote:
> On Tue, 2023-07-04 at 08:59 +0200, M. Haener wrote:
> > From: Michael Haener <[email protected]>
> >
> > This patch series brings SERDES support for the mv88e632x family.
>
> Changelog:
> v2: rebased onto Russell Kings series dsa/88e6xxx/phylink
Russell King will be interested in a Tested-by: for his patchset.
That will also help get that patchset merged so yours can then
follow. So please keep an eye on the netdev list, and repost your
patches once Russells have been merged.
Andrew
On Tue, 4 Jul 2023 08:59:03 +0200 M. Haener wrote:
> This patch series brings SERDES support for the mv88e632x family.
Not sure if this was said already - you'll need to repost once
Russell's patches are merged. It's a good practice to send patches
with unmet dependencies as RFC.
On Wed, 2023-07-05 at 01:31 +0200, Andrew Lunn wrote:
> On Tue, Jul 04, 2023 at 07:17:55AM +0000, Haener, Michael wrote:
> > On Tue, 2023-07-04 at 08:59 +0200, M. Haener wrote:
> > > From: Michael Haener <[email protected]>
> > >
> > > This patch series brings SERDES support for the mv88e632x family.
> >
> > Changelog:
> > v2: rebased onto Russell Kings series dsa/88e6xxx/phylink
>
> Russell King will be interested in a Tested-by: for his patchset.
> That will also help get that patchset merged so yours can then
> follow. So please keep an eye on the netdev list, and repost your
> patches once Russells have been merged.
>
> Andrew
Once the other patch is merged, I will rebase this patch and resubmit.
On Thu, Jul 06, 2023 at 06:51:51AM +0000, Haener, Michael wrote:
> On Wed, 2023-07-05 at 01:31 +0200, Andrew Lunn wrote:
> > On Tue, Jul 04, 2023 at 07:17:55AM +0000, Haener, Michael wrote:
> > > On Tue, 2023-07-04 at 08:59 +0200, M. Haener wrote:
> > > > From: Michael Haener <[email protected]>
> > > >
> > > > This patch series brings SERDES support for the mv88e632x family.
> > >
> > > Changelog:
> > > v2: rebased onto Russell Kings series dsa/88e6xxx/phylink
> >
> > Russell King will be interested in a Tested-by: for his patchset.
> > That will also help get that patchset merged so yours can then
> > follow. So please keep an eye on the netdev list, and repost your
> > patches once Russells have been merged.
> >
> > ????????Andrew
>
> Once the other patch is merged, I will rebase this patch and resubmit.
From your response, I can only assume you have not understood Andrew's
comment.
Andrew is asking you to _test_ my patch set, and _then_ give a
Tested-by. It's useless to do that after my patch set has been merged.
This will give more confidence to my patch set when I submit it. Since
I'll be doing so maybe later today, you'll probably have to reply to
the series once it's been posted.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Hi Russell,
On Thu, 2023-07-13 at 07:42 +0100, Russell King (Oracle) wrote:
> > > > Changelog:
> > > > v2: rebased onto Russell Kings series dsa/88e6xxx/phylink
> > >
> > > Russell King will be interested in a Tested-by: for his patchset.
> > > That will also help get that patchset merged so yours can then
> > > follow. So please keep an eye on the netdev list, and repost your
> > > patches once Russells have been merged.
> > >
> > > Andrew
> >
> > Once the other patch is merged, I will rebase this patch and resubmit.
>
> From your response, I can only assume you have not understood Andrew's
> comment.
we did understand Andrew's request indeed, however we were not able to
backport your series quickly to the version we are able to test on the
HW. Michael's patch is less invasive and we were able to port it easier.
Thanks for your understanding!
> Andrew is asking you to _test_ my patch set, and _then_ give a
> Tested-by. It's useless to do that after my patch set has been merged.
> This will give more confidence to my patch set when I submit it. Since
> I'll be doing so maybe later today, you'll probably have to reply to
> the series once it's been posted.
--
Alexander Sverdlin
Siemens AG
http://www.siemens.com
> we did understand Andrew's request indeed, however we were not able to
> backport your series quickly to the version we are able to test on the
> HW.
But your own patchset has been tested on net-next by yourself? So it
should be trivial to use "b4 am <threadid>" to get Russells patchset,
apply them on top of net-next, and then add your patches as well.
Andrew
On Thu, Jul 13, 2023 at 05:34:25PM +0200, Andrew Lunn wrote:
> > we did understand Andrew's request indeed, however we were not able to
> > backport your series quickly to the version we are able to test on the
> > HW.
>
> But your own patchset has been tested on net-next by yourself? So it
> should be trivial to use "b4 am <threadid>" to get Russells patchset,
> apply them on top of net-next, and then add your patches as well.
And it's even easier as today I submitted a patch set on top of current
net-next - not that there were any conflicts.
https://lore.kernel.org/netdev/[email protected]/T/#t
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Hi Andrew,
On Thu, 2023-07-13 at 17:34 +0200, Andrew Lunn wrote:
> > we did understand Andrew's request indeed, however we were not able to
> > backport your series quickly to the version we are able to test on the
> > HW.
>
> But your own patchset has been tested on net-next by yourself? So it
> should be trivial to use "b4 am <threadid>" to get Russells patchset,
> apply them on top of net-next, and then add your patches as well.
unfortunately it has been only built on net-next and tested on a 5.15.x with some
limited backports so that Russell series would require even more backporting.
--
Alexander Sverdlin
Siemens AG
http://www.siemens.com
On Thu, Jul 13, 2023 at 04:29:12PM +0000, Sverdlin, Alexander wrote:
> Hi Andrew,
>
> On Thu, 2023-07-13 at 17:34 +0200, Andrew Lunn wrote:
> > > we did understand Andrew's request indeed, however we were not able to
> > > backport your series quickly to the version we are able to test on the
> > > HW.
> >
> > But your own patchset has been tested on net-next by yourself? So it
> > should be trivial to use "b4 am <threadid>" to get Russells patchset,
> > apply them on top of net-next, and then add your patches as well.
>
> unfortunately it has been only built on net-next and tested on a 5.15.x with some
> limited backports so that Russell series would require even more backporting.
You should indicate that the patch is only built tested when
submitting it.
I assume you are using a vendor kernel? What is missing in mainline to
stop networking working?
Andrew
Hello Andrew,
On Thu, 2023-07-13 at 21:33 +0200, Andrew Lunn wrote:
> On Thu, Jul 13, 2023 at 04:29:12PM +0000, Sverdlin, Alexander wrote:
> > Hi Andrew,
> >
> > On Thu, 2023-07-13 at 17:34 +0200, Andrew Lunn wrote:
> > > > we did understand Andrew's request indeed, however we were not able to
> > > > backport your series quickly to the version we are able to test on the
> > > > HW.
> > >
> > > But your own patchset has been tested on net-next by yourself? So it
> > > should be trivial to use "b4 am <threadid>" to get Russells patchset,
> > > apply them on top of net-next, and then add your patches as well.
> >
> > unfortunately it has been only built on net-next and tested on a 5.15.x with some
> > limited backports so that Russell series would require even more backporting.
>
> You should indicate that the patch is only built tested when
> submitting it.
yes, it's not tested on the HW with net-net.
It's tested with older kernel with DSA backported to 6.1+ kernel.
> I assume you are using a vendor kernel? What is missing in mainline to
> stop networking working?
If we talk networking, my patch "net: fec: Defer probe if other FEC has deferred MDIO"
comes to my mind, this is quite important, but didn't gain much interest.
But network is usually not the critical part, it's usually other SoC parts and it's
not always easy to plug a Gigabit Switch out and plug it into a HW running fresh kernel.
We are improving on this, but this is a balancing act between being creative on
testing and not upstreaming at all.
--
Alexander Sverdlin
Siemens AG
http://www.siemens.com