2023-07-04 07:45:09

by Minjie Du

Subject: [PATCH v1] drivers: scsi: remove duplicate logical judgments

Fix: delate duplicate logical judgments.
Please check this. Thank you!

Signed-off-by: Minjie Du <[email protected]>
---
drivers/scsi/qlogicfas408.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/qlogicfas408.c b/drivers/scsi/qlogicfas408.c
index 3e065d5fc..d2f92672b 100644
--- a/drivers/scsi/qlogicfas408.c
+++ b/drivers/scsi/qlogicfas408.c
@@ -594,8 +594,7 @@ void qlogicfas408_setup(int qbase, int id, int int_type)
int qlogicfas408_detect(int qbase, int int_type)
{
REG1;
- return (((inb(qbase + 0xe) ^ inb(qbase + 0xe)) == 7) &&
- ((inb(qbase + 0xe) ^ inb(qbase + 0xe)) == 7));
+ return ((inb(qbase + 0xe) ^ inb(qbase + 0xe)) == 7);
}

/*
--
2.39.0

2023-07-04 15:37:33

by Bart Van Assche

Subject: Re: [PATCH v1] drivers: scsi: remove duplicate logical judgments

On 7/4/23 00:37, Minjie Du wrote:
> Please check this.

Without feedback from someone who has access to the datasheet this patch
probably should not be applied. The repeated inb() calls may be on purpose.

Thanks,

Bart.