2023-07-03 03:18:10

by Li zeming

Subject: [PATCH] kprobes: Remove unnecessary ‘0’ values from ret

ret is assigned first, so it does not need to initialize the assignment.

Signed-off-by: Li zeming <[email protected]>
---
kernel/kprobes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 00e177de91cc..db8a3aa53cf6 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -1072,7 +1072,7 @@ static int kprobe_ftrace_enabled;
static int __arm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops,
int *cnt)
{
- int ret = 0;
+ int ret;

lockdep_assert_held(&kprobe_mutex);

@@ -1110,7 +1110,7 @@ static int arm_kprobe_ftrace(struct kprobe *p)
static int __disarm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops,
int *cnt)
{
- int ret = 0;
+ int ret;

lockdep_assert_held(&kprobe_mutex);

--
2.18.2

2023-07-06 13:56:53

by Masami Hiramatsu

Subject: Re: [PATCH] kprobes: Remove unnecessary ‘0’ values from ret

On Wed, 5 Jul 2023 03:21:07 +0800
Li zeming <[email protected]> wrote:

> ret is assigned first, so it does not need to initialize the assignment.
>
> Signed-off-by: Li zeming <[email protected]>

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <[email protected]>

Thank you!

> ---
> kernel/kprobes.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 00e177de91cc..db8a3aa53cf6 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1072,7 +1072,7 @@ static int kprobe_ftrace_enabled;
> static int __arm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops,
> int *cnt)
> {
> - int ret = 0;
> + int ret;
>
> lockdep_assert_held(&kprobe_mutex);
>
> @@ -1110,7 +1110,7 @@ static int arm_kprobe_ftrace(struct kprobe *p)
> static int __disarm_kprobe_ftrace(struct kprobe *p, struct ftrace_ops *ops,
> int *cnt)
> {
> - int ret = 0;
> + int ret;
>
> lockdep_assert_held(&kprobe_mutex);
>
> --
> 2.18.2
>


--
Masami Hiramatsu (Google) <[email protected]>